Attachment 164364 Details for Bug 33568 – Bug 33568: Hide 'Host records' if EasyAnalyticalRecords is off

[patch] Bug 33568: Hide 'Host records' if EasyAnalyticalRecords is off

Bug-33568-Hide-Host-records-if-EasyAnalyticalRecor.patch (text/plain), 3.09 KB, created by Jonathan Druart on 2024-04-03 07:41:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-04-03 07:41:31 UTC

Size: 3.09 KB

patch

obsolete

>From 648afa180c8bda1b380e873ca62dff4661c35294 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 30 Oct 2023 16:55:20 +0100
>Subject: [PATCH] Bug 33568: Hide 'Host records' if EasyAnalyticalRecords is
> off
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Signed-off-by: TomÃ¡s Cohen Arazi <tomascohen@theke.io>
>---
> .../html_helpers/tables/items/catalogue_detail.inc     | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index 8ee98b918b4..09aeb5af134 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -35,7 +35,7 @@
>             <th id="[% tab | html %]_materials" data-colname="[% tab | html %]_materials">Materials specified</th>
>             <th id="[% tab | html %]_itemnotes" data-colname="[% tab | html %]_itemnotes">Public notes</th>
>             <th id="[% tab | html %]_itemnotes_nonpublic" data-colname="[% tab | html %]_itemnotes_nonpublic">Non-public notes</th>
>-            <th id="[% tab | html %]_hostrecord" data-colname="[% tab | html %]_hostrecord">Host records</th>
>+            [% IF Koha.Preference('EasyAnalyticalRecords') %]<th id="[% tab | html %]_hostrecord" data-colname="[% tab | html %]_hostrecord">Host records</th>[% END %]
>             [% IF ( analyze ) %]<th id="[% tab | html %]_usedin" data-colname="[% tab | html %]_usedin">Used in</th><th></th>[% END %]
>             [% IF Koha.Preference('UseCourseReserves') %]<th id="[% tab | html %]_course_reserves" data-colname="[% tab | html %]_course_reserves">Course reserves</th>[% END %]
>             [% IF ( SpineLabelShowPrintOnBibDetails ) %]<th id="[% tab | html %]_spinelabel" data-colname="[% tab | html %]_spinelabel" class="NoSort">Spine label</th>[% END %]
>@@ -222,8 +222,10 @@
>         embed.push('course_item.course_reserves.course');
>     [% END %]
> 
>-    // For host records
>-    embed.push('biblio.title');
>+    [% IF Koha.Preference('EasyAnalyticalRecords') %]
>+        // For host records
>+        embed.push('biblio.title');
>+    [% END %]
> 
>     [% IF analyze %]
>         embed.push('analytics_count');
>@@ -659,6 +661,7 @@
>                     return escape_str(row.internal_notes);
>                 }
>             },
>+            [% IF Koha.Preference('EasyAnalyticalRecords') %]
>             {
>                 data: "biblio.title",
>                 searchable: false,
>@@ -668,6 +671,7 @@
>                     return '<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=%s">%s</a>'.format(row.biblio_id, row.biblio.title);
>                 }
>             },
>+            [% END %]
>             [% IF analyze %]
>             {
>                 data: "analytics_count",
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33568: 151339 | 153791 | 164308 | 164309 | 164310 | 164311 | 164312 | 164313 | 164314 | 164315 | 164316 | 164317 | 164318 | 164319 | 164320 | 164321 | 164322 | 164323 | 164324 | 164325 | 164326 | 164327 | 164328 | 164329 | 164330 | 164331 | 164332 | 164333 | 164334 | 164335 | 164336 | 164337 | 164338 | 164339 | 164340 | 164341 | 164342 | 164343 | 164344 | 164345 | 164346 | 164347 | 164348 | 164349 | 164350 | 164351 | 164352 | 164353 | 164354 | 164355 | 164356 | 164358 | 164359 | 164360 | 164361 | 164362 | 164363 | 164364 | 164365 | 164366 | 164367 | 164368 | 164369 | 164370 | 164371 | 164372 | 164373 | 164374 | 164472 | 164480 | 164482 | 164483 | 164485 | 164528