Attachment 164371 Details for Bug 33568 – Bug 33568: Remove LPAD ordering

[patch] Bug 33568: Remove LPAD ordering

Bug-33568-Remove-LPAD-ordering.patch (text/plain), 3.53 KB, created by Jonathan Druart on 2024-04-03 07:42:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-04-03 07:42:04 UTC

Size: 3.53 KB

patch

obsolete

>From cde589c85791f9bce6b1fdfd2a3a4e64b6afd64d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 1 Feb 2024 16:29:24 +0100
>Subject: [PATCH] Bug 33568: Remove LPAD ordering
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This is coming from bug 3521 it seems. And we are going to deal with
>this later if people complains.
>
>kidclamp> the performance issue for sites with many copies is bigger than sorting issues imho
>kidclamp> drop the LPAD I say :-)
>
>Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Signed-off-by: TomÃ¡s Cohen Arazi <tomascohen@theke.io>
>---
> Koha/Items.pm               |  4 ----
> Koha/REST/V1/Biblios.pm     |  1 -
> t/db_dependent/Koha/Items.t | 13 ++-----------
> 3 files changed, 2 insertions(+), 16 deletions(-)
>
>diff --git a/Koha/Items.pm b/Koha/Items.pm
>index 03fd6da0ac3..f3edb776856 100644
>--- a/Koha/Items.pm
>+++ b/Koha/Items.pm
>@@ -466,13 +466,9 @@ sub search_ordered {
>         return $self->search(
>             {},
>             {
>-                '+select' => [{
>-                    lpad => ['copynumber', \8, \"'0'"], '-as' => 'lpad_copynumber',
>-                }],
>                 order_by => [
>                     'homebranch.branchname',
>                     'me.enumchron',
>-                    'lpad_copynumber',
>                     {-desc => 'me.dateaccessioned'}
>                 ],
>                 join => ['homebranch']
>diff --git a/Koha/REST/V1/Biblios.pm b/Koha/REST/V1/Biblios.pm
>index 59d4c62f297..edb51653146 100644
>--- a/Koha/REST/V1/Biblios.pm
>+++ b/Koha/REST/V1/Biblios.pm
>@@ -307,7 +307,6 @@ sub get_items {
>         $items_rs = $items_rs->filter_by_bookable if $bookable_only;
>         # FIXME We need to order_by serial.publisheddate if we have _order_by=+me.serial_issue_number
>         my $items = $c->objects->search($items_rs);
>-        delete $_->{lpad_copynumber} for @$items;
> 
>         return $c->render(
>             status  => 200,
>diff --git a/t/db_dependent/Koha/Items.t b/t/db_dependent/Koha/Items.t
>index a7e1fc72c16..c29200e9a04 100755
>--- a/t/db_dependent/Koha/Items.t
>+++ b/t/db_dependent/Koha/Items.t
>@@ -1792,7 +1792,7 @@ subtest 'move_to_biblio() tests' => sub {
> 
> subtest 'search_ordered' => sub {
> 
>-    plan tests => 9;
>+    plan tests => 8;
> 
>     $schema->storage->txn_begin;
> 
>@@ -1824,17 +1824,8 @@ subtest 'search_ordered' => sub {
>             [ $item3->itemnumber, $item2->itemnumber, $item1->itemnumber ],
>             "not a serial - order by enumchron" );
> 
>-        # order_by LPAD( me.copynumber, 8, '0' )
>-        $biblio->items->update( { enumchron => undef } );
>-        $item1->discard_changes->update( { copynumber => '12345678' } );
>-        $item2->discard_changes->update( { copynumber => '34567890' } );
>-        $item3->discard_changes->update( { copynumber => '23456789' } );
>-        is_deeply( [ map { $_->itemnumber } $biblio->items->search_ordered->as_list ],
>-            [ $item1->itemnumber, $item3->itemnumber, $item2->itemnumber ],
>-            "not a serial - order by LPAD( me.copynumber, 8, '0' )" );
>-
>         # order_by -desc => 'me.dateaccessioned'
>-        $biblio->items->update( { copynumber => undef } );
>+        $biblio->items->update( { enumchron => undef } );
>         $item1->discard_changes->update( { dateaccessioned => '2022-08-19' } );
>         $item2->discard_changes->update( { dateaccessioned => '2022-07-19' } );
>         $item3->discard_changes->update( { dateaccessioned => '2022-09-19' } );
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33568: 151339 | 153791 | 164308 | 164309 | 164310 | 164311 | 164312 | 164313 | 164314 | 164315 | 164316 | 164317 | 164318 | 164319 | 164320 | 164321 | 164322 | 164323 | 164324 | 164325 | 164326 | 164327 | 164328 | 164329 | 164330 | 164331 | 164332 | 164333 | 164334 | 164335 | 164336 | 164337 | 164338 | 164339 | 164340 | 164341 | 164342 | 164343 | 164344 | 164345 | 164346 | 164347 | 164348 | 164349 | 164350 | 164351 | 164352 | 164353 | 164354 | 164355 | 164356 | 164358 | 164359 | 164360 | 164361 | 164362 | 164363 | 164364 | 164365 | 164366 | 164367 | 164368 | 164369 | 164370 | 164371 | 164372 | 164373 | 164374 | 164472 | 164480 | 164482 | 164483 | 164485 | 164528