Bugzilla – Attachment 164375 Details for
Bug 36416
Check out using CirculateILL is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36416: Fix cud-check_out
Bug-36416-Fix-cud-checkout.patch (text/plain), 1.92 KB, created by
David Nind
on 2024-04-03 07:50:19 UTC
(
hide
)
Description:
Bug 36416: Fix cud-check_out
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-04-03 07:50:19 UTC
Size:
1.92 KB
patch
obsolete
>From 1bf76f2111aa5183ae0f6f79a6871e85a3bb44fc Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Mon, 25 Mar 2024 13:23:36 +0000 >Subject: [PATCH] Bug 36416: Fix cud-check_out > >1) Install FreeForm and enable ILLModule, run: >bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) >2) Checkout to branch b_36243 >cd /kohadevbox/koha/Koha/Illbackends/FreeForm >git checkout b_36243 >3) Enable CirculateILL sys pref >4) Create a new ILL request, visit: ><staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm >5) Set "type" = Book and enter '42' on the cardnumber input, click "Create" >6) On the top toolbar, click "Confirm" and confirm the following screen. >7) You now have a new option "Check out" on the toolbar. Click on it. Notice it explodes. >8) Apply patch. Repeat. > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/Illrequest.pm | 1 + > ill/ill-requests.pl | 1 + > 2 files changed, 2 insertions(+) > >diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm >index 9dfe275eff..c45b74f57d 100644 >--- a/Koha/Illrequest.pm >+++ b/Koha/Illrequest.pm >@@ -2087,6 +2087,7 @@ sub get_op_param_deprecation { > $op = 'cud-generic_confirm' if $op eq 'generic_confirm'; > $op = 'cud-cancel' if $op eq 'cancel'; > $op = 'cud-delete' if $op eq 'delete'; >+ $op = 'cud-check_out' if $op eq 'check_out'; > } > return $op; > } >diff --git a/ill/ill-requests.pl b/ill/ill-requests.pl >index 9087825a0d..0ed7afb6f6 100755 >--- a/ill/ill-requests.pl >+++ b/ill/ill-requests.pl >@@ -369,6 +369,7 @@ if ( $backends_available ) { > # handle special commit rules & update type > handle_commit_maybe($backend_result, $request); > } elsif ( $op eq 'cud-check_out') { >+ $op =~ s/^cud-//; > my $request = Koha::Illrequests->find($params->{illrequest_id}); > my $backend_result = $request->check_out($params); > $template->param( >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36416
:
163802
|
164375
|
164678