Attachment 164451 Details for Bug 36036 – Bug 36036: Fix misnamed location field

[patch] Bug 36036: Fix misnamed location field

Bug-36036-Fix-misnamed-location-field.patch (text/plain), 3.21 KB, created by Marcel de Rooy on 2024-04-05 07:01:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-04-05 07:01:49 UTC

Size: 3.21 KB

patch

obsolete

>From 3f9ce1f2970076a6499f3c39e232ed6ec30623cf Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Thu, 8 Feb 2024 11:11:24 +0000
>Subject: [PATCH] Bug 36036: Fix misnamed location field
>MIME-Version: 1.0
>Content-Type: text/plain; charset=utf-8
>Content-Transfer-Encoding: 8bit
>Content-Type: text/plain; charset=utf-8
>
>This patch fixes a hash reference in the template to allow the location field to display properly
>
>Test plan:
>1) In system preferences, click Search and then select the Acquisitions option from the left hand menu
>2) Paste the following into MarcFieldsToOrder
>price: 975$p
>quantity: 975$q
>budget_code: 975$h
>3) Paste the following into MarcItemFieldsToOrder
>homebranch: 949$a
>holdingbranch: 949$b
>itype: 949$y
>nonpublic_note: 949$x
>public_note: 949$z
>loc: 949$c
>ccode: 949$8
>notforloan: 949$7
>uri: 949$u
>copyno: 949$t
>price: 949$g
>replacementprice: 949$v
>itemcallnumber: 949$o
>quantity: 949$k
>budget_code: 949$l
>Now save the sysprefs
>4) Navigate to acquisitions and go into a basket
>5) Click Add to basket and select âFrom a new fileâ
>6) Download the file attached to this bug
>7) Import the file and when the job is complete click âAdd staged files to basketâ
>8) Click the checkbox next to the record to display the items
>9) Inspect the value for the "loc" field - the value of "AV" from the file has not been selected
>10) Apply patch and refresh the page
>11) On inspection the value should now be properly selected
>
>Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt      | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
>index b0c1eba563..a7a1d1b4ff 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
>@@ -297,7 +297,7 @@
>                                                                                     <select id="loc_item_[% item.item_id | html %]" name="loc_[% biblio.import_record_id | html %]">
>                                                                                         <option value=""> </option>
>                                                                                         [% FOREACH locationloo IN locationloop %]
>-                                                                                            [% IF ( locationloo.code ) == (item.loc) %]
>+                                                                                            [% IF ( locationloo.code ) == (item.location) %]
>                                                                                                 <option value="[% locationloo.code | html %]" selected="selected">[% locationloo.description | html %]</option>
>                                                                                             [% ELSE %]
>                                                                                                 <option value="[% locationloo.code | html %]">[% locationloo.description | html %]</option>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36036: 161886 | 161887 | 161925 | 164451