Attachment 164456 Details for Bug 36343 – Bug 36343: (QA follow-up) Adjust two other occurrences

[patch] Bug 36343: (QA follow-up) Adjust two other occurrences

Bug-36343-QA-follow-up-Adjust-two-other-occurrence.patch (text/plain), 1.62 KB, created by Marcel de Rooy on 2024-04-05 07:34:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-04-05 07:34:05 UTC

Size: 1.62 KB

patch

obsolete

>From b109f91fc9db97275b086b4b2540cd475ec3da7c Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 5 Apr 2024 07:29:40 +0000
>Subject: [PATCH] Bug 36343: (QA follow-up) Adjust two other occurrences
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Item.pm   | 5 +++--
> Koha/Patron.pm | 6 +++++-
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/Item.pm b/Koha/Item.pm
>index 59edeb752d..4a1c85dbd9 100644
>--- a/Koha/Item.pm
>+++ b/Koha/Item.pm
>@@ -2016,8 +2016,9 @@ sub _after_item_action_hooks {
>         'after_item_action',
>         {
>             action  => $action,
>-            item    => $self,
>-            item_id => $self->itemnumber,
>+            item    => $self,                                             #FIXME To be deprecated
>+            item_id => $self->itemnumber,                                 #FIXME To be deprecated
>+            payload => { item => $self, item_id => $self->itemnumber },
>         }
>     );
> }
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index 3778be7937..e322dfdad3 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -2062,7 +2062,11 @@ sub has_valid_userid {
> sub generate_userid {
>     my ( $self ) = @_;
>     my @responses = Koha::Plugins->call(
>-        'patron_generate_userid', { patron => $self },
>+        'patron_generate_userid',
>+        {
>+            patron  => $self,                 #FIXME To be deprecated
>+            payload => { patron => $self },
>+        },
>     );
>     unless( @responses ) {
>         # Empty list only possible when there are NO enabled plugins for this method.
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36343: 163328 | 163768 | 164455 | 164456 | 164910