Attachment 164485 Details for Bug 33568 – Bug 33568: Prevent api/v1/biblios.t to fail randomly

[patch] Bug 33568: Prevent api/v1/biblios.t to fail randomly

Bug-33568-Prevent-apiv1bibliost-to-fail-randomly.patch (text/plain), 1.58 KB, created by Jonathan Druart on 2024-04-05 14:48:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-04-05 14:48:08 UTC

Size: 1.58 KB

patch

obsolete

>From a1cfde1cd6ba65432bdfaccedc9c22383227348b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 5 Apr 2024 16:34:02 +0200
>Subject: [PATCH] Bug 33568: Prevent api/v1/biblios.t to fail randomly
>
>koha_1       |     #   Failed test 'The items are returned'
>koha_1       |     #   at t/db_dependent/api/v1/biblios.t line 196.
>koha_1       |     #     Structures begin differing at:
>koha_1       |     #          $got->[0]{external_id} = 'th151O2JtgfGdVW6aiF'
>koha_1       |     #     $expected->[0]{external_id} = 'uxrMzUXrkHQy7MHOSfjK'
>koha_1       |     # Looks like you failed 1 test of 11.
>koha_1       |
>koha_1       | #   Failed test 'get_items() tests'
>koha_1       | #   at t/db_dependent/api/v1/biblios.t line 206.
>---
> t/db_dependent/api/v1/biblios.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/api/v1/biblios.t b/t/db_dependent/api/v1/biblios.t
>index fdb148a8807..b7e51a046f7 100755
>--- a/t/db_dependent/api/v1/biblios.t
>+++ b/t/db_dependent/api/v1/biblios.t
>@@ -193,7 +193,7 @@ subtest 'get_items() tests' => sub {
>     my $item_1 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });
>     my $item_2 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });
> 
>-    $t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/items")
>+    $t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/items?_order_by=item_id" )
>       ->status_is(200)
>       ->json_is( '' => [ $item_1->to_api, $item_2->to_api ], 'The items are returned' );
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33568: 151339 | 153791 | 164308 | 164309 | 164310 | 164311 | 164312 | 164313 | 164314 | 164315 | 164316 | 164317 | 164318 | 164319 | 164320 | 164321 | 164322 | 164323 | 164324 | 164325 | 164326 | 164327 | 164328 | 164329 | 164330 | 164331 | 164332 | 164333 | 164334 | 164335 | 164336 | 164337 | 164338 | 164339 | 164340 | 164341 | 164342 | 164343 | 164344 | 164345 | 164346 | 164347 | 164348 | 164349 | 164350 | 164351 | 164352 | 164353 | 164354 | 164355 | 164356 | 164358 | 164359 | 164360 | 164361 | 164362 | 164363 | 164364 | 164365 | 164366 | 164367 | 164368 | 164369 | 164370 | 164371 | 164372 | 164373 | 164374 | 164472 | 164480 | 164482 | 164483 | 164485 | 164528