Bugzilla – Attachment 164489 Details for
Bug 35980
Add message to patron needs permission check
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35980: Check for CAN_user_borrowers_edit_borrowers in patron-toolbar.inc
Bug-35980-Check-for-CANuserborrowerseditborrowers-.patch (text/plain), 3.93 KB, created by
ByWater Sandboxes
on 2024-04-05 18:05:00 UTC
(
hide
)
Description:
Bug 35980: Check for CAN_user_borrowers_edit_borrowers in patron-toolbar.inc
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2024-04-05 18:05:00 UTC
Size:
3.93 KB
patch
obsolete
>From baeb1721df8789d73889a9a2b18920d26143fbcd Mon Sep 17 00:00:00 2001 >From: Brendan Lawlor <blawlor@clamsnet.org> >Date: Thu, 4 Apr 2024 18:29:07 +0000 >Subject: [PATCH] Bug 35980: Check for CAN_user_borrowers_edit_borrowers in > patron-toolbar.inc > >This patch removes the 'New patron' and 'Quick add new patron' buttons from the patron tool bar that's included on members-home.pl > >To test: >1. Log in with a user with only 'catalogue', 'list_borrowers' and 'manage_patron_lists' permissions >2. From the main page click on Patrons >3. Notice there are 'New patron' and 'Quick add new patron' buttons in the members-home.pl page that lead to permissions errors >4. Apply patch, restart all, reload the page >5. Notice the buttons to add new patrons are gone, but the button to manage patron lists is still there > >Signed-off-by: Esther <esther@bywatersolutions.com> >--- > .../prog/en/includes/patron-toolbar.inc | 28 ++++++++++--------- > 1 file changed, 15 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc >index f4c2295483..924c1563b8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc >@@ -4,19 +4,21 @@ > > [% UNLESS ( no_add ) %] > <div id="toolbar" class="btn-toolbar"> >- <div class="btn-group" id="new-patron-button"> >- <button class="btn btn-default dropdown-toggle" data-toggle="dropdown"><i class="fa fa-plus"></i> New patron <span class="caret"></span></button> >- <ul class="dropdown-menu"> >- [% FOREACH category IN categories %]<li><a href="/cgi-bin/koha/members/memberentry.pl?op=add_form&categorycode=[% category.categorycode | uri %]">[% category.description | html %]</a></li>[% END %] >- </ul> >- </div> >- [% IF Koha.Preference('PatronQuickAddFields') || Koha.Preference('BorrowerMandatoryField') %] >- <div class="btn-group" id="quick-add-new-patron-button"> >- <button class="btn btn-default dropdown-toggle" data-toggle="dropdown"><i class="fa fa-plus"></i> Quick add new patron <span class="caret"></span></button> >- <ul class="dropdown-menu"> >- [% FOREACH category IN categories %]<li><a href="/cgi-bin/koha/members/memberentry.pl?op=add_form&categorycode=[% category.categorycode | uri %]&quickadd=true">[% category.description | html %]</a></li>[% END %] >- </ul> >- </div> >+ [% IF CAN_user_borrowers_edit_borrowers %] >+ <div class="btn-group" id="new-patron-button"> >+ <button class="btn btn-default dropdown-toggle" data-toggle="dropdown"><i class="fa fa-plus"></i> New patron <span class="caret"></span></button> >+ <ul class="dropdown-menu"> >+ [% FOREACH category IN categories %]<li><a href="/cgi-bin/koha/members/memberentry.pl?op=add_form&categorycode=[% category.categorycode | uri %]">[% category.description | html %]</a></li>[% END %] >+ </ul> >+ </div> >+ [% IF Koha.Preference('PatronQuickAddFields') || Koha.Preference('BorrowerMandatoryField') %] >+ <div class="btn-group" id="quick-add-new-patron-button"> >+ <button class="btn btn-default dropdown-toggle" data-toggle="dropdown"><i class="fa fa-plus"></i> Quick add new patron <span class="caret"></span></button> >+ <ul class="dropdown-menu"> >+ [% FOREACH category IN categories %]<li><a href="/cgi-bin/koha/members/memberentry.pl?op=add_form&categorycode=[% category.categorycode | uri %]&quickadd=true">[% category.description | html %]</a></li>[% END %] >+ </ul> >+ </div> >+ [% END %] > [% END %] > [% IF CAN_user_tools_manage_patron_lists %] > <a class="btn btn-default" href="/cgi-bin/koha/patron_lists/lists.pl" id="patron-lists-button"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Patron lists</a> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35980
:
164433
|
164434
|
164435
|
164488
|
164489
|
164623
|
164624
|
164625