Attachment 164494 Details for Bug 36379 – Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search

[patch] Bug 36379: Fix auth_finder.pl to not expect the op cud-do_search

Bug-36379-Fix-authfinderpl-to-not-expect-the-op-cu.patch (text/plain), 1.81 KB, created by Julian Maurice on 2024-04-08 08:22:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2024-04-08 08:22:54 UTC

Size: 1.81 KB

patch

obsolete

>From ad05359dcf82800290372cda83e1a939e6ffb700 Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Thu, 4 Apr 2024 16:28:53 -0700
>Subject: [PATCH] Bug 36379: Fix auth_finder.pl to not expect the op
> cud-do_search
>
>The authority finder just does a GET for a list of search results, it
>doesn't create or update or delete, so the template that thinks the op
>is do_search is correct.
>
>Test plan:
>1. Cataloging - New record
>2. In the 1 tab click the Tag editor icon at the end of 100 subfield a
>3. In the popup, click Search, and nothing happens, no results are shown.
>4. Apply patch, reset_all
>5. Repeat steps 1-3, see that you get results.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> authorities/auth_finder.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/authorities/auth_finder.pl b/authorities/auth_finder.pl
>index 21a7209aeb..1603fbbc31 100755
>--- a/authorities/auth_finder.pl
>+++ b/authorities/auth_finder.pl
>@@ -41,7 +41,7 @@ my $relationship = $query->param('relationship') || '';
> 
> my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>     {
>-        template_name => ( $op eq 'cud-do_search' )
>+        template_name => ( $op eq 'do_search' )
>         ? 'authorities/searchresultlist-auth.tt'
>         : 'authorities/auth_finder.tt',
>         query           => $query,
>@@ -53,7 +53,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
> my $authority_types = Koha::Authority::Types->search( {}, { order_by => ['authtypetext'] } );
> 
> # If search form posted
>-if ( $op eq "cud-do_search" ) {
>+if ( $op eq "do_search" ) {
>     my @marclist  = $query->multi_param('marclist');
>     my @and_or    = $query->multi_param('and_or');
>     my @excluding = $query->multi_param('excluding');
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36379: 164442 | 164464 | 164494