Bugzilla – Attachment 16455 Details for
Bug 8015
Add MARC Modifications Templates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8015: Fix problem with moving existing subfield value to nonexistent field/subfield
Bug-8015-Fix-problem-with-moving-existing-subfield.patch (text/plain), 1.73 KB, created by
Paul Poulain
on 2013-03-20 08:44:04 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8015: Fix problem with moving existing subfield value to nonexistent field/subfield
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2013-03-20 08:44:04 UTC
Size:
1.73 KB
patch
obsolete
>From 4818fa9275b2f4d291e68cb80a4b624183563ebf Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 19 Mar 2013 09:24:18 -0700 >Subject: [PATCH] Bug 8015: Fix problem with moving existing subfield value to nonexistent field/subfield > >Signed-off-by: Leila <koha.aixmarseille@gmail.com> >--- > Koha/SimpleMARC.pm | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Koha/SimpleMARC.pm b/Koha/SimpleMARC.pm >index f7f872b..1d8c486 100644 >--- a/Koha/SimpleMARC.pm >+++ b/Koha/SimpleMARC.pm >@@ -262,7 +262,7 @@ sub field_equals { > sub move_field { > my ( $record, $fromFieldName, $fromSubfieldName, $toFieldName, $toSubfieldName, $regex, $n ) = @_; > C4::Koha::Log( "C4::SimpleMARC::move_field( '$record', '$fromFieldName', '$fromSubfieldName', '$toFieldName', '$toSubfieldName', '$regex', '$n' )" ) if $debug; >- copy_field( $record, $fromFieldName, $fromSubfieldName, $toFieldName, $toSubfieldName, $regex, $n , "don't_erase"); >+ copy_field( $record, $fromFieldName, $fromSubfieldName, $toFieldName, $toSubfieldName, $regex, $n , 1); > delete_field( $record, $fromFieldName, $fromSubfieldName, $n ); > } > >@@ -316,11 +316,11 @@ sub _update_repeatable_field_with_single_value { > if ( $subfieldName ) { > if ( my @fields = $record->field( $fieldName ) ) { > foreach my $field ( @fields ) { >- $field->update( "$subfieldName" => $value ); >+ $field->update( $subfieldName => $value ); > } > } else { > ## Field does not exist, create it. >- $field = MARC::Field->new( $fieldName, '', '', "$subfieldName" => $value ); >+ $field = MARC::Field->new( $fieldName, undef, undef, $subfieldName => $value ); > $record->append_fields( $field ); > } > } else { ## No subfield >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8015
:
9313
|
9329
|
9330
|
9331
|
10089
|
11579
|
11607
|
11608
|
12280
|
12288
|
12569
|
12570
|
12571
|
12572
|
12839
|
12856
|
12857
|
12858
|
12859
|
12860
|
13121
|
13138
|
13495
|
14030
|
14031
|
14032
|
14033
|
14034
|
14035
|
14040
|
16330
|
16331
|
16332
|
16333
|
16334
|
16335
|
16363
|
16376
|
16377
|
16378
|
16379
|
16413
|
16415
|
16423
|
16455
|
16468
|
16470
|
16471
|
16472
|
16473
|
16475
|
16476
|
16477
|
16478
|
16479
|
16480
|
17036
|
17037
|
17038
|
18372
|
18441
|
21024
|
21025
|
21026
|
21027
|
21028
|
21029
|
21030
|
21031
|
21032
|
21033
|
21034
|
21035
|
21036
|
21037
|
21038
|
21371
|
21484
|
21485
|
21486
|
21487
|
21808
|
21809
|
21876
|
21901
|
21902
|
21903
|
21904
|
21905
|
21906
|
21907
|
21908
|
21909
|
21910
|
21911
|
21912
|
21913
|
21914
|
21915
|
21916
|
21917
|
21918
|
21919
|
21920
|
22185
|
22186
|
22187
|
22188
|
22189
|
22190
|
22284
|
22285
|
22290
|
22293
|
22392
|
22393
|
22394
|
22395
|
22396
|
22397
|
22398
|
22399
|
22400
|
22401