Attachment 164552 Details for Bug 6796 – Bug 6796: Code defensively for if library hours are not set

[patch] Bug 6796: Code defensively for if library hours are not set

Bug-6796-Code-defensively-for-if-library-hours-are.patch (text/plain), 1.08 KB, created by Martin Renvoize (ashimema) on 2024-04-09 09:58:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-04-09 09:58:14 UTC

Size: 1.08 KB

patch

obsolete

>From 84758d350bb430e7e99de6b9b4da3eff1af0cfa3 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 13 Feb 2024 09:21:06 +0000
>Subject: [PATCH] Bug 6796: Code defensively for if library hours are not set
>
>Sponsored-by: PTFS Europe
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Circulation.pm | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 8fa89866e6e..b454ff241f8 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -3911,6 +3911,10 @@ sub CalcDateDue {
>     my @close         = undef;
>     my $tomorrowhours = Koha::Library::Hours->find( { library_id => $branch, day => $tomorrow_dayofweek } )
>         ;    # get open hours of next day
>+
>+    # Defend against missing library hours definitions
>+    if ( !$todayhours || !$tomorrowhours ) { $considerlibraryhours = 'ignore' }
>+
>     my @open = undef;
>     if ( $considerlibraryhours ne 'ignore' and $todayhours->close_time and $tomorrowhours->open_time ) {
>         @close             = split( ":", $todayhours->close_time );
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 6796: 124669 | 124670 | 124671 | 124672 | 134323 | 134324 | 134325 | 134326 | 134327 | 145669 | 145670 | 145671 | 145672 | 145673 | 146988 | 146989 | 146990 | 146991 | 146992 | 150442 | 150443 | 150444 | 150445 | 150446 | 150447 | 150448 | 150477 | 150478 | 153252 | 153253 | 153254 | 153255 | 153256 | 153257 | 153258 | 153259 | 153260 | 153261 | 153271 | 153272 | 153273 | 153274 | 153275 | 153276 | 153277 | 153278 | 153279 | 153280 | 156772 | 156773 | 156774 | 156775 | 156776 | 156777 | 156778 | 156779 | 156780 | 161970 | 161971 | 161972 | 161973 | 161974 | 161975 | 161976 | 161977 | 161978 | 161979 | 161980 | 161986 | 161987 | 161988 | 161989 | 162043 | 162044 | 162045 | 162046 | 162047 | 162048 | 162049 | 162050 | 162051 | 162052 | 162053 | 162054 | 162055 | 162056 | 162090 | 162091 | 162092 | 162093 | 162094 | 162095 | 162096 | 162097 | 162098 | 162099 | 162100 | 162101 | 162102 | 162103 | 162104 | 164511 | 164512 | 164513 | 164514 | 164515 | 164516 | 164517 | 164518 | 164538 | 164539 | 164540 | 164541 | 164542 | 164543 | 164544 | 164545 | 164546 | 164547 | 164548 | 164549 | 164550 | 164551 | 164552