Bugzilla – Attachment 164564 Details for
Bug 36555
Add report_id to file name when exporting report results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36555: Add report_id to download file name
Bug-36555-Add-reportid-to-download-file-name.patch (text/plain), 1.20 KB, created by
Andrew Fuerste-Henry
on 2024-04-09 14:53:05 UTC
(
hide
)
Description:
Bug 36555: Add report_id to download file name
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2024-04-09 14:53:05 UTC
Size:
1.20 KB
patch
obsolete
>From 8655e39ec8cad181c28b39d42c6b1e30634b4b0b Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrewfh@dubcolib.org> >Date: Tue, 9 Apr 2024 14:51:17 +0000 >Subject: [PATCH] Bug 36555: Add report_id to download file name > >To test: >- apply patch, restart all >- run a report >- export results >- confirm file name is the report ID, followed by report name >--- > reports/guided_reports.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index 3196731163..3618e4c633 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -619,7 +619,7 @@ elsif ($op eq 'export'){ > my @sql_params = $input->multi_param('sql_params'); > my $format = $input->param('format'); > my $reportname = $input->param('reportname'); >- my $reportfilename = $reportname ? "$reportname-reportresults.$format" : "reportresults.$format" ; >+ my $reportfilename = $reportname ? "$report_id-$reportname-reportresults.$format" : "$report_id-reportresults.$format" ; > > ($sql, undef) = $report->prep_report( \@param_names, \@sql_params ); > my ( $sth, $q_errors ) = execute_query( { sql => $sql, report_id => $report_id } ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36555
:
164564
|
164565
|
165954
|
165955