Attachment 164593 Details for Bug 23102 – Bug 23102: 404 errors on page causes SCI user to be logged out

[patch] Bug 23102: 404 errors on page causes SCI user to be logged out

Bug-23102-404-errors-on-page-causes-SCI-user-to-be.patch (text/plain), 1.84 KB, created by Martin Renvoize (ashimema) on 2024-04-10 09:51:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-04-10 09:51:49 UTC

Size: 1.84 KB

patch

obsolete

>From d30354495fe2251e29f87e66b69516dfd51f18de Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 12 Jun 2019 11:43:48 +0000
>Subject: [PATCH] Bug 23102: 404 errors on page causes SCI user to be logged
> out
>
>To test:
> 1 - Have something on the SCO page that won't load
>     Add to SCOUserJS:
>        </script>
>        <img src="http://localhost:8080/silk/famfamfam.png"/>
>        <script>
> 2 - Enable the SCO and SCI system preferences:
>     WebBasedSelfCheck: Enable
>     SelfCheckInModuke: Enable
>     AutoSelfCheckAllowed: Allow
>     AutoSelfCheckID / AutoSelfCheckPass to a valid user with permissions
> 3 - Add the self_checkin_module and self_checkout_module permissions to the AutoSelfCheck user
> 4 - Access the selfcheckout module https://yoursite.org/cgi-bin/koha/sco/sco-main.pl
> 5 - Sign in using a patron
> 6 - Enter an unkown barcode, I used "DONTMATTER"
> 7 - If not logged out, click to 'Return to account summary'
> 8 - You are asked to sign in again
> 9 - Repeat with the SCI module
>10 - Apply patch
>11 - Repeat, but this time you can return to account
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Auth.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index 86ddd3baf09..e3478ea6913 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -256,7 +256,7 @@ sub get_template_and_user {
> # If the user logged in is the SCI user and they try to go out of the SCI module,
> # kick them out unless it is SCO with a valid permission
> # or they are a superlibrarian
>-               $in->{template_name} !~ m|sci/|
>+            $in->{template_name} !~ m|sci/| && $in->{template_name} !~ m|errors/errorpage.tt|
>             && haspermission( $user, { self_check => 'self_checkin_module' } )
>             && !(
>                 $in->{template_name} =~ m|sco/| && haspermission(
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 23102: 90528 | 97581 | 98977 | 98978 | 148423 | 148424 | 148425 | 148426 | 148601 | 148767 | 148768 | 154691 | 154692 | 163358 | 163359 | 164591 | 164592 | 164593 | 164819