Bugzilla – Attachment 164626 Details for
Bug 36517
Fix output from install_plugins.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36517: Fix output from install_plugins.pl
Bug-36517-Fix-output-from-installpluginspl.patch (text/plain), 1.73 KB, created by
Emily Lamancusa (emlam)
on 2024-04-10 13:20:28 UTC
(
hide
)
Description:
Bug 36517: Fix output from install_plugins.pl
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2024-04-10 13:20:28 UTC
Size:
1.73 KB
patch
obsolete
>From ca6f1bc225d141cc5130788a4dcaf80684b46b4b Mon Sep 17 00:00:00 2001 >From: Magnus Enger <magnus@libriotech.no> >Date: Fri, 5 Apr 2024 13:41:08 +0000 >Subject: [PATCH] Bug 36517: Fix output from install_plugins.pl > >When misc/devel/install_plugins.pl does not find any plugins, it prints >the list of pluginsdir, but with a literal \n separating the dirs, and >no newline at the end. > >To test: >- Edit koha-conf.xml and add a second entry for <pluginsdir>, so there > are two entries. The second one could just be a copy of the original. >- Run "perl misc/devel/install_plugins.pl" >- Note the output looks something like this: > >No plugins found >pluginsdir contains: >/var/lib/koha/kohadev/plugins\n/var/lib/koha/kohadev/pluginsroot@kohadevbox:koha(master)$ > >- Apply the patch and run the script again. Output should be: > >No plugins found >pluginsdir contains: >/var/lib/koha/kohadev/plugins >/var/lib/koha/kohadev/plugins >root@kohadevbox:koha(master)$ > >- Sign off > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > misc/devel/install_plugins.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/misc/devel/install_plugins.pl b/misc/devel/install_plugins.pl >index 98d7691c6e..2ccc68a15b 100755 >--- a/misc/devel/install_plugins.pl >+++ b/misc/devel/install_plugins.pl >@@ -51,7 +51,7 @@ unless (@installed_plugins) { > my $plugins_dir = C4::Context->config("pluginsdir"); > if ( ref($plugins_dir) eq 'ARRAY' ) { > print "No plugins found\n"; >- print "pluginsdir contains: \n" . join( '\n', @{$plugins_dir} ); >+ print "pluginsdir contains: \n" . join( "\n", @{$plugins_dir} ) . "\n"; > } > else { > print "No plugins found at $plugins_dir\n"; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36517
:
164477
|
164493
| 164626