Attachment 164678 Details for Bug 36416 – Bug 36416: Fix cud-check_out

[patch] Bug 36416: Fix cud-check_out

Bug-36416-Fix-cud-checkout.patch (text/plain), 1.99 KB, created by Martin Renvoize (ashimema) on 2024-04-11 12:11:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-04-11 12:11:41 UTC

Size: 1.99 KB

patch

obsolete

>From 2bd5a5aa7313196114be28efb7d42ff0c2e95fb3 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Mon, 25 Mar 2024 13:23:36 +0000
>Subject: [PATCH] Bug 36416: Fix cud-check_out
>
>1) Install FreeForm and enable ILLModule, run:
>bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
>2) Checkout to branch b_36243
>cd /kohadevbox/koha/Koha/Illbackends/FreeForm
>git checkout b_36243
>3) Enable CirculateILL sys pref
>4) Create a new ILL request, visit:
><staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm
>5) Set "type" = Book and enter '42' on the cardnumber input, click "Create"
>6) On the top toolbar, click "Confirm" and confirm the following screen.
>7) You now have a new option "Check out" on the toolbar. Click on it. Notice it explodes.
>8) Apply patch. Repeat.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Illrequest.pm  | 1 +
> ill/ill-requests.pl | 1 +
> 2 files changed, 2 insertions(+)
>
>diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm
>index 9dfe275eff0..c45b74f57de 100644
>--- a/Koha/Illrequest.pm
>+++ b/Koha/Illrequest.pm
>@@ -2087,6 +2087,7 @@ sub get_op_param_deprecation {
>         $op = 'cud-generic_confirm' if $op eq 'generic_confirm';
>         $op = 'cud-cancel' if $op eq 'cancel';
>         $op = 'cud-delete' if $op eq 'delete';
>+        $op = 'cud-check_out' if $op eq 'check_out';
>     }
>     return $op;
> }
>diff --git a/ill/ill-requests.pl b/ill/ill-requests.pl
>index 9087825a0d6..0ed7afb6f6a 100755
>--- a/ill/ill-requests.pl
>+++ b/ill/ill-requests.pl
>@@ -369,6 +369,7 @@ if ( $backends_available ) {
>         # handle special commit rules & update type
>         handle_commit_maybe($backend_result, $request);
>     } elsif ( $op eq 'cud-check_out') {
>+        $op =~ s/^cud-//;
>         my $request = Koha::Illrequests->find($params->{illrequest_id});
>         my $backend_result = $request->check_out($params);
>         $template->param(
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 36416: 163802 | 164375 | 164678