Bugzilla – Attachment 164774 Details for
Bug 36568
Changing rows per page on a custom report is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36568: Fix id parameter in template
Bug-36568-Fix-id-parameter-in-template.patch (text/plain), 1.77 KB, created by
Nick Clemens (kidclamp)
on 2024-04-11 15:35:40 UTC
(
hide
)
Description:
Bug 36568: Fix id parameter in template
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-04-11 15:35:40 UTC
Size:
1.77 KB
patch
obsolete
>From af041b3395672339e8a94fd3a569886cc68b180e Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Wed, 10 Apr 2024 12:54:22 -0400 >Subject: [PATCH] Bug 36568: Fix id parameter in template > >Fix missed case of changing parameter name from "reports" to "id" > >To test: >1. Find or create an SQL report that will return more than 20 rows >2. Run the report >3. Change the "Rows per page" drop-down to a new value >--> An empty page is displayed! >4. Apply patch >5. Repeat steps 2-3 >--> The report is displayed with the appropriate number of results > >Signed-off-by: David Cook <dcook@prosentient.com.au> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > .../prog/en/modules/reports/guided_reports_start.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 04eafbfa85a..157c538b507 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -1031,7 +1031,7 @@ > > <form action="/cgi-bin/koha/reports/guided_reports.pl" method="get" id="limitselect"> > <input type="hidden" name="op" value="run"/> >- <input type="hidden" name="reports" value="[% id | html %]"/> >+ <input type="hidden" name="id" value="[% id | html %]"/> > [% FOREACH p IN sql_params %] > <input type="hidden" name="sql_params" value="[% p | html %]"/> > [% END %] >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36568
:
164629
|
164641
| 164774