Bugzilla – Attachment 164790 Details for
Bug 20388
Ability to add search fields from UI
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20388: Adjust code
Bug-20388-Adjust-code.patch (text/plain), 3.07 KB, created by
Nick Clemens (kidclamp)
on 2024-04-12 07:38:52 UTC
(
hide
)
Description:
Bug 20388: Adjust code
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-04-12 07:38:52 UTC
Size:
3.07 KB
patch
obsolete
>From 1c6b8a596fd5d3949759cc5d3b1d4fc38293f8b8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 19 Mar 2024 15:28:30 +0100 >Subject: [PATCH] Bug 20388: Adjust code > >Sponsored-by: The Research University in the Helmholtz Association (KIT) >Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> >Signed-off-by: David Schmidt <davewood@gmx.at> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > .../prog/js/elasticsearch-mappings.js | 35 +++++++++---------- > 1 file changed, 16 insertions(+), 19 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js b/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js >index db67f7fd531..325d2c23cf5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js >@@ -90,11 +90,6 @@ $(document).ready(function () { > let dt = $('#' + table_id).DataTable(); > dt.row.add(new_line).draw(); > >- var search_field_line = $('input[name="search_field_name"][value="' + search_field_name + '"]').closest("tr"); >- $(search_field_line).find('a.btn-default').addClass('disabled'); >- >- clean_line(line); >- > $(table).on( 'click', '.delete', function () { > var table = $(this).closest('table'); > let dt = $(table).DataTable(); >@@ -128,23 +123,25 @@ $(document).ready(function () { > > $('.add-search-field').click(function() { > var table = $(this).closest('table'); >- var line = $(this).closest("tr"); >- var name = $(line).find('input[data-id="search_field_name"]').val(); >- let already_exist = 0; >+ let table_id = table.attr('id'); >+ var line = $(this).closest('tr'); >+ var search_field_name = $(line).find('input[data-id="search_field_name"]').val(); >+ if (search_field_name.length > 0) { >+ var new_line = clone_line(line); >+ new_line.find('td:first').attr({'data-order': search_field_name}); >+ new_line.appendTo($('table#' + table_id + '>tbody')); >+ let dt = $('#' + table_id).DataTable(); >+ dt.row.add(new_line).draw(); > >- if ( $('input[name="search_field_name"][value="' + name + '"]').val() ) { >- already_exist = 1; >- } >+ $(table).on( 'click', '.delete', function () { >+ var table = $(this).closest('table'); >+ let dt = $(table).DataTable(); >+ dt.row( $(this).closest('tr') ).remove().draw(); >+ } ); > >- if (already_exist) { >- alert("SearchField "+ name + " already exist"); >+ clean_line(line); > } else { >- var label = $(line).find('input[data-id="search_field_label"]').val(); >- if ( name.length > 0 && label.length > 0 ) { >- var new_line = clone_line( line ); >- new_line.appendTo(table.find('tbody')); >- clean_line(line); >- } >+ alert("SearchField "+ name + " already exist"); > } > }); > }); >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20388
:
73158
|
73165
|
73167
|
73476
|
73626
|
73627
|
73629
|
73681
|
73682
|
73918
|
73919
|
73940
|
73943
|
73944
|
73945
|
73946
|
74261
|
74718
|
74719
|
78658
|
78659
|
80709
|
86912
|
87196
|
87197
|
87198
|
87199
|
87201
|
87202
|
87203
|
87204
|
88075
|
88079
|
88080
|
88081
|
88082
|
88083
|
89117
|
89118
|
89121
|
89733
|
89894
|
90517
|
90518
|
90519
|
90520
|
90521
|
90522
|
90523
|
90524
|
98011
|
98012
|
98013
|
98014
|
98015
|
98016
|
98017
|
98018
|
99960
|
99961
|
99962
|
99963
|
99964
|
99965
|
99966
|
99967
|
119296
|
119317
|
119318
|
120104
|
163449
|
163450
|
163451
|
163452
|
163460
|
163461
|
163462
|
163463
|
164529
|
164530
|
164531
|
164532
|
164533
|
164534
|
164535
|
164789
| 164790 |
164791
|
164792
|
164793