Attachment 164819 Details for Bug 23102 – Bug 23102: No mock in selenium

[patch] Bug 23102: No mock in selenium

Bug-23102-No-mock-in-selenium.patch (text/plain), 1.67 KB, created by Nick Clemens (kidclamp) on 2024-04-12 09:50:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-04-12 09:50:32 UTC

Size: 1.67 KB

patch

obsolete

>From 887b895610804946422ff73be19f7db85f5ef070 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 12 Apr 2024 09:46:20 +0000
>Subject: [PATCH] Bug 23102: No mock in selenium
>
>---
> t/db_dependent/selenium/regressions.t | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t
>index 3ac80ad0be2..8425953ad23 100755
>--- a/t/db_dependent/selenium/regressions.t
>+++ b/t/db_dependent/selenium/regressions.t
>@@ -60,7 +60,8 @@ subtest 'SCI can load error pages' => sub {
> 
>     my $builder = t::lib::TestBuilder->new;
>     my $patron  = $builder->build_object( { class => 'Koha::Patrons', value => { flags => 0 } } );
>-    t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
>+    my $rsp     = C4::Context->preference('RequireStrongPassword');
>+    C4::Context->set_preference( 'RequireStrongPassword', '0' );
>     my $password = Koha::AuthUtils::generate_password( $patron->category );
>     $patron->set_password( { password => $password } );
> 
>@@ -86,8 +87,9 @@ subtest 'SCI can load error pages' => sub {
>     $s->driver->find_element('//form[@id="scan_form"]//button[@id="sci_checkin_button"]')->click;
>     like( $driver->get_title(), qr(Self check-in), );
> 
>-    C4::Context->set_preference( 'SelfCheckInUserJS', $sci_js );
>-    C4::Context->set_preference( 'SelfCheckInModule', $sci_mo );
>+    C4::Context->set_preference( 'SelfCheckInUserJS',     $sci_js );
>+    C4::Context->set_preference( 'SelfCheckInModule',     $sci_mo );
>+    C4::Context->set_preference( 'RequireStrongPassword', $rsp );
>     push @cleanup, $patron, $patron->category, $patron->library;
> };
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 23102: 90528 | 97581 | 98977 | 98978 | 148423 | 148424 | 148425 | 148426 | 148601 | 148767 | 148768 | 154691 | 154692 | 163358 | 163359 | 164591 | 164592 | 164593 | 164819