Bugzilla – Attachment 164832 Details for
Bug 36246
Have a centralized method for submitting a form via a link
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36246: (follow-up) Fix confirm
Bug-36246-follow-up-Fix-confirm.patch (text/plain), 1.16 KB, created by
Nick Clemens (kidclamp)
on 2024-04-12 11:51:54 UTC
(
hide
)
Description:
Bug 36246: (follow-up) Fix confirm
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-04-12 11:51:54 UTC
Size:
1.16 KB
patch
obsolete
>From ba9cd57c21d251d0c2dedc5ca2e20fcdb488f827 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 12 Apr 2024 11:50:34 +0000 >Subject: [PATCH] Bug 36246: (follow-up) Fix confirm > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/js/form-submit.js | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/form-submit.js b/koha-tmpl/intranet-tmpl/prog/js/form-submit.js >index 05625b8d8b5..dc19d1bb77a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/form-submit.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/form-submit.js >@@ -5,12 +5,11 @@ $(document).ready(function(){ > let form_data = $(this).data(); > > let confirm_msg = form_data.confirmationMsg; >- let confirmation = 1; > if( confirm_msg ){ >+ let confirmation = confirm( confirm_msg ); >+ if( !confirmation ){ return false; } > delete form_data.confirmationMsg; >- confirmation = confirm( confirm_msg ); > } >- if( !confirmation ){ return false } > > let the_form = $('<form/>'); > if( form_data.method === 'post' ){ >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36246
:
162835
|
163098
|
163517
|
164830
|
164831
|
164832
|
165967
|
165968
|
165969
|
165970
|
165971