Bugzilla – Attachment 164844 Details for
Bug 36597
Cannot delete circulation desk
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36597: Fix deletion of circulation desks broken by CSRF
Bug-36597-Fix-deletion-of-circulation-desks-broken.patch (text/plain), 1.27 KB, created by
Owen Leonard
on 2024-04-12 12:33:45 UTC
(
hide
)
Description:
Bug 36597: Fix deletion of circulation desks broken by CSRF
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2024-04-12 12:33:45 UTC
Size:
1.27 KB
patch
obsolete
>From 4fccb2475f2037e436e3c2aa8f908e4f1c2f7caf Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 12 Apr 2024 12:31:15 +0000 >Subject: [PATCH] Bug 36597: Fix deletion of circulation desks broken by CSRF > >Our CSRF work introduced a problem with deleting circulation desks: The >"delete_confirm" does not need "cud-" because it's a GET operation >leading to a POSTed deletion after the confirmation is submitted. > >To test, apply the patch and restart services. > >- Go to Administration -> Circulation desks. >- If necessary, create a circulation desk. >- Click the "Delete" button for you new desk. >- You should be taken to a confirmation page which shows details of the > desk you're deleting. >- Confirming the deletion should result in deletion of the desk. >--- > admin/desks.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/desks.pl b/admin/desks.pl >index 02ec4e5115d..c688cf17534 100755 >--- a/admin/desks.pl >+++ b/admin/desks.pl >@@ -82,7 +82,7 @@ if ( $op eq 'add_form' ) { > } > $searchfield = q||; > $op = 'list'; >-} elsif ( $op eq 'cud-delete_confirm' ) { >+} elsif ( $op eq 'delete_confirm' ) { > my $desk = Koha::Desks->find($desk_id); > $template->param( desk => $desk, ); > } elsif ( $op eq 'cud-delete_confirmed' ) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36597
:
164844
|
164845
|
164988