Bugzilla – Attachment 16493 Details for
Bug 7674
Separate tabs for my holdings and others holdings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7674: Hide empty items tab
Bug-7674-Hide-empty-items-tab.patch (text/plain), 1.49 KB, created by
Brendan Gallagher
on 2013-03-20 11:13:09 UTC
(
hide
)
Description:
Bug 7674: Hide empty items tab
Filename:
MIME Type:
Creator:
Brendan Gallagher
Created:
2013-03-20 11:13:09 UTC
Size:
1.49 KB
patch
obsolete
>From fd9d408d9707a2a7c006e44050218b36eb82f89c Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Thu, 10 Jan 2013 17:01:37 +0100 >Subject: [PATCH] Bug 7674: Hide empty items tab > >Signed-off-by: Brendan <brendan@bywatersolutions.com> >--- > catalogue/detail.pl | 8 ++++++++ > opac/opac-detail.pl | 8 ++++++++ > 2 files changed, 16 insertions(+), 0 deletions(-) > >diff --git a/catalogue/detail.pl b/catalogue/detail.pl >index ec6f6eb..a5b32c6 100755 >--- a/catalogue/detail.pl >+++ b/catalogue/detail.pl >@@ -281,6 +281,14 @@ foreach my $item (@items) { > } > } > >+# Display only one tab if one items list is empty >+if (scalar(@itemloop) == 0 || scalar(@otheritemloop) == 0) { >+ $template->param(SeparateHoldings => 0); >+ if (scalar(@itemloop) == 0) { >+ @itemloop = @otheritemloop; >+ } >+} >+ > $template->param( norequests => $norequests ); > $template->param( > MARCNOTES => $marcnotesarray, >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 068122e..769ace5 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -576,6 +576,14 @@ for my $itm (@items) { > } > } > >+# Display only one tab if one items list is empty >+if (scalar(@itemloop) == 0 || scalar(@otheritemloop) == 0) { >+ $template->param(SeparateHoldings => 0); >+ if (scalar(@itemloop) == 0) { >+ @itemloop = @otheritemloop; >+ } >+} >+ > # If there is a lot of items, and the user has not decided > # to view them all yet, we first warn him > # TODO: The limit of 50 could be a syspref >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7674
:
12416
|
12417
|
12418
|
12433
|
12749
|
12750
|
13002
|
13003
|
13189
|
13190
|
13191
|
13204
|
13205
|
13206
|
13207
|
13215
|
13832
|
13833
|
13834
|
13835
|
13990
|
13991
|
13992
|
13993
|
14082
|
14111
|
14528
|
16493
|
16502