Bugzilla – Attachment 165078 Details for
Bug 36473
updatetotalissues.pl should not die on a bad record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36473: (follow-up) Add biblionumber to warning
Bug-36473-follow-up-Add-biblionumber-to-warning.patch (text/plain), 1.79 KB, created by
Nick Clemens (kidclamp)
on 2024-04-18 10:36:24 UTC
(
hide
)
Description:
Bug 36473: (follow-up) Add biblionumber to warning
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-04-18 10:36:24 UTC
Size:
1.79 KB
patch
obsolete
>From b7787deb3f0296972295186b519488506a6dd6ed Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 18 Apr 2024 10:35:52 +0000 >Subject: [PATCH] Bug 36473: (follow-up) Add biblionumber to warning > >--- > C4/Biblio.pm | 2 +- > t/db_dependent/Biblio.t | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 4455262b7e0..170e9f9cd97 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -3062,7 +3062,7 @@ sub UpdateTotalIssues { > if ($@) { > my $exception = $@; > $exception->rethrow unless ( $exception->isa('Koha::Exceptions::Metadata::Invalid') ); >- warn "UpdateTotalIssues could not get bibliographic record"; >+ warn "UpdateTotalIssues could not get bibliographic record for biblionumber $biblionumber"; > return; > } > my $biblioitem = $biblio->biblioitem; >diff --git a/t/db_dependent/Biblio.t b/t/db_dependent/Biblio.t >index 28cdb78c10a..c920d2a3925 100755 >--- a/t/db_dependent/Biblio.t >+++ b/t/db_dependent/Biblio.t >@@ -1029,6 +1029,7 @@ subtest 'UpdateTotalIssues on Invalid record' => sub { > $return_record->mock( 'record', sub { Koha::Exceptions::Metadata::Invalid->throw() } ); > > my $biblio = $builder->build_sample_biblio; >+ my $biblionumber = $biblio->biblionumber; > > my $increase = 1; > >@@ -1036,7 +1037,7 @@ subtest 'UpdateTotalIssues on Invalid record' => sub { > warning_is { > $success = C4::Biblio::UpdateTotalIssues( $biblio->biblionumber, $increase, '' ); > } >- "UpdateTotalIssues could not get bibliographic record", "Expected warning found"; >+ "UpdateTotalIssues could not get bibliographic record for biblionumber $biblionumber", "Expected warning found"; > > ok( !$success, 'UpdateTotalIssues fails gracefully for invalid record' ); > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36473
:
164192
|
164247
|
164269
|
164270
|
164271
|
164289
|
164290
|
164458
|
164459
|
164805
|
164806
|
165039
|
165077
| 165078 |
165079