Attachment 165097 Details for Bug 35100 – Bug 35100: Prevent StockrotationAdvance transfers from being cancelled

[patch] Bug 35100: Prevent StockrotationAdvance transfers from being cancelled

Bug-35100-Prevent-StockrotationAdvance-transfers-f.patch (text/plain), 1.85 KB, created by Nick Clemens (kidclamp) on 2024-04-18 13:33:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-04-18 13:33:54 UTC

Size: 1.85 KB

patch

obsolete

>From 0731c05ad8d3439f38710c054afe2535b0dbebd6 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 4 Jan 2024 12:00:13 +0000
>Subject: [PATCH] Bug 35100: Prevent StockrotationAdvance transfers from being
> cancelled
>
>ModItemTransfer is still very heavy handed and outright overrules
>existing transfers in the queue.
>
>For StockrotationAdvance transfers it's important that they remain in
>the queue to get actioned later, even if a higher precident transfer is
>actions in the interim.
>
>This patch adds a clause to the cancellation call within
>request_transfer such that StockrationAdvance transfers are left in tact
>for the next time the item is checked in.
>
>Test plan
>1) Item is added to stock rotation
>2) The cronjob creates a 'StockRotationAdvance' transfer
>3) The item is checked in, which initiates the transfer, however, a hold is triggered
>4) The hold is confirmed, which replaces the StockRotationAdvance
>5) The item is checked out
>6) The item is checked in, which initiates the transfer again
>7) The item is checked in at it's destination and the StockrotationAdvance transfer
>   has the proper date arrived date set.
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Item.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Item.pm b/Koha/Item.pm
>index d9c89be3cd5..0f2dc167b44 100644
>--- a/Koha/Item.pm
>+++ b/Koha/Item.pm
>@@ -761,7 +761,7 @@ sub request_transfer {
>       if ( $request && !$params->{enqueue} && !$params->{replace} );
> 
>     $request->cancel( { reason => $params->{reason}, force => 1 } )
>-      if ( defined($request) && $params->{replace} );
>+        if ( defined($request) && $params->{replace} && ( $request->reason ne 'StockrotationAdvance' ) );
> 
>     my $transfer = Koha::Item::Transfer->new(
>         {
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 35100: 160514 | 160515 | 160557 | 160558 | 160575 | 160623 | 160628 | 160641 | 160642 | 160643 | 160647 | 160648 | 160687 | 160688 | 160689 | 160690 | 162740 | 162741 | 162742 | 162743 | 162744 | 162745 | 162746 | 162747 | 162757 | 162758 | 162759 | 162760 | 162761 | 162762 | 165096 | 165097 | 165098 | 165099 | 165100 | 165101 | 168273 | 168274 | 168275 | 168276 | 168277 | 168278 | 169347 | 169348 | 169349 | 169350 | 169351 | 169352 | 169353 | 171530 | 171531 | 171532 | 171533 | 171534 | 171535 | 171559 | 171560 | 171561 | 171562 | 171563 | 171564