Attachment 165101 Details for Bug 35100 – Bug 35100: (follow-up) Tidy

[patch] Bug 35100: (follow-up) Tidy

Bug-35100-follow-up-Tidy.patch (text/plain), 2.32 KB, created by Nick Clemens (kidclamp) on 2024-04-18 13:34:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-04-18 13:34:03 UTC

Size: 2.32 KB

patch

obsolete

>From 851787e9e10c78e77b241f085b85903aa8952099 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 5 Mar 2024 12:38:02 +0000
>Subject: [PATCH] Bug 35100: (follow-up) Tidy
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/RotatingCollections.pm        | 10 +++++-----
> t/db_dependent/SIP/Transaction.t |  2 +-
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/C4/RotatingCollections.pm b/C4/RotatingCollections.pm
>index 41d14d45aa4..a31938343b2 100644
>--- a/C4/RotatingCollections.pm
>+++ b/C4/RotatingCollections.pm
>@@ -487,11 +487,11 @@ sub TransferCollection {
>                             replace       => 1
>                         }
>                     );    # Replace transfer
>-                    # FIXME: If we just replaced a StockRotationAdvance,
>-                    # it will get enqueued afresh on the next cron run.. but
>-                    # that will also push the stage on too.. and what about if
>-                    # we were at the first stage.. then there won't be a datearrived
>-                    # to calculate against. See bug 35100
>+                          # FIXME: If we just replaced a StockRotationAdvance,
>+                          # it will get enqueued afresh on the next cron run.. but
>+                          # that will also push the stage on too.. and what about if
>+                          # we were at the first stage.. then there won't be a datearrived
>+                          # to calculate against. See bug 35100
>                 }
>             }
>             elsif ( $_->isa('Koha::Exceptions::Item::Transfer::Limit') ) {
>diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t
>index fdb595c6151..11ed6305051 100755
>--- a/t/db_dependent/SIP/Transaction.t
>+++ b/t/db_dependent/SIP/Transaction.t
>@@ -405,7 +405,7 @@ subtest do_checkin => sub {
>     $ci_transaction->do_checkin( $library->branchcode, undef );
>     is( $patron->checkouts->count, 0, 'Checkin should have been done successfully' );
> 
>-    my $result = $ci_transaction->do_checkin( $library2->branchcode, undef );
>+    my $result   = $ci_transaction->do_checkin( $library2->branchcode, undef );
>     my $transfer = $item->get_transfer;
>     is( $ci_transaction->alert_type, '04', "Checkin of item no issued at another branch succeeds" );
>     is_deeply(
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 35100: 160514 | 160515 | 160557 | 160558 | 160575 | 160623 | 160628 | 160641 | 160642 | 160643 | 160647 | 160648 | 160687 | 160688 | 160689 | 160690 | 162740 | 162741 | 162742 | 162743 | 162744 | 162745 | 162746 | 162747 | 162757 | 162758 | 162759 | 162760 | 162761 | 162762 | 165096 | 165097 | 165098 | 165099 | 165100 | 165101 | 168273 | 168274 | 168275 | 168276 | 168277 | 168278 | 169347 | 169348 | 169349 | 169350 | 169351 | 169352 | 169353 | 171530 | 171531 | 171532 | 171533 | 171534 | 171535 | 171559 | 171560 | 171561 | 171562 | 171563 | 171564