Attachment 165274 Details for Bug 35919 – Bug 35919: (QA follow-up) Address QA concerns

[patch] Bug 35919: (QA follow-up) Address QA concerns

Bug-35919-QA-follow-up-Address-QA-concerns.patch (text/plain), 4.88 KB, created by Tomás Cohen Arazi (tcohen) on 2024-04-22 12:28:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2024-04-22 12:28:18 UTC

Size: 4.88 KB

patch

obsolete

>From 8fedea5c17c212abe611381338df8b52acf49297 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 22 Apr 2024 09:25:08 -0300
>Subject: [PATCH] Bug 35919: (QA follow-up) Address QA concerns
>
>This patch:
>
>* Adds the missing entry in permissions.inc
>* Moves the configuration entry above 'Record overlay rules'
>* Adds the 'Record sources' link to the left navigation column, in the
> right position.
>* Makes the <title> element be constructed the same way the 'cities'
> page is.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc | 3 +++
> koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc | 6 ++++++
> .../intranet-tmpl/prog/en/modules/admin/admin-home.tt | 8 ++++----
> .../intranet-tmpl/prog/en/modules/admin/record_sources.tt | 8 +++++---
> 4 files changed, 18 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc
>index c7caffc0143..3aa5b87b95a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc
>@@ -104,6 +104,9 @@
> [% IF ( CAN_user_parameters_manage_matching_rules ) %]
> <li><a href="/cgi-bin/koha/admin/matching-rules.pl">Record matching rules</a></li>
> [% END %]
>+ [% IF ( CAN_user_parameters_manage_record_sources ) %]
>+ <li><a href="/cgi-bin/koha/admin/record_sources">Record sources</a></li>
>+ [% END %]
> [% IF ( CAN_user_parameters_manage_marc_overlay_rules ) %]
> <li><a href="/cgi-bin/koha/admin/marc-overlay-rules.pl">Record overlay rules</a></li>
> [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>index 742e6e1c359..a5768e54c59 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>@@ -872,5 +872,11 @@
> Manage identity providers
> 
> ([% name | html %])
>+ [%# record_sources %]
>+ [%- CASE 'manage_record_sources' -%]
>+ 
>+ Manage record sources
>+ 
>+ ([% name | html %])
> [%- END -%]
> [%- END -%]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
>index 8f920678ba6..a3948f60634 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
>@@ -190,6 +190,10 @@
> <dt><a href="/cgi-bin/koha/admin/matching-rules.pl">Record matching rules</a></dt>
> <dd>Manage rules for automatically matching MARC records during record imports</dd>
> [% END %]
>+ [% IF ( CAN_user_parameters_manage_record_sources ) %]
>+ <dt><a href="/cgi-bin/koha/admin/record_sources">Record sources</a></dt>
>+ <dd>Define record sources to import from</dd>
>+ [% END %]
> [% IF ( CAN_user_parameters_manage_marc_overlay_rules ) %]
> <dt><a href="/cgi-bin/koha/admin/marc-overlay-rules.pl">Record overlay rules</a></dt>
> <dd>Managed rules for automatic overlay of MARC fields during record imports and updates</dd>
>@@ -210,10 +214,6 @@
> <dt><a href="/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl">Search engine configuration (Elasticsearch)</a></dt>
> <dd>Manage indexes, facets, and their mappings to MARC fields and subfields</dd>
> [% END %]
>- [% IF ( CAN_user_parameters_manage_record_sources ) %]
>- <dt><a href="/cgi-bin/koha/admin/record_sources">Record sources</a></dt>
>- <dd>Define record sources to import from</dd>
>- [% END %]
> </dl>
> [% END %]
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/record_sources.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/record_sources.tt
>index 533a171ec2c..3ceff704930 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/record_sources.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/record_sources.tt
>@@ -7,9 +7,11 @@
> [% SET footerjs = 1 %]
> [% PROCESS 'i18n.inc' %]
> [% INCLUDE 'doc-head-open.inc' %]
>-<title>
>- Record sources &rsaquo; Koha
>-</title>
>+<title>[% FILTER collapse %]
>+ [% t("Record sources") | html %] &rsaquo;
>+ [% t("Administration") | html %] &rsaquo;
>+ [% t("Koha") | html %]
>+[% END %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
> </head>
> 
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 35919: 161531 | 161532 | 161533 | 161534 | 161535 | 161537 | 161538 | 161577 | 161578 | 161579 | 161580 | 161581 | 161582 | 161583 | 162489 | 162594 | 162595 | 162596 | 162599 | 163348 | 163349 | 163350 | 163351 | 163352 | 163353 | 163354 | 163355 | 163360 | 163369 | 163389 | 163390 | 163391 | 163392 | 163393 | 163394 | 163395 | 163396 | 163397 | 163398 | 163399 | 163400 | 164708 | 164709 | 164710 | 164711 | 164712 | 164713 | 164714 | 164715 | 164716 | 164717 | 165274