Attachment 165275 Details for Bug 36649 – Bug 36649: Correctly embed biblio when retrieving items when adding to a train

[patch] Bug 36649: Correctly embed biblio when retrieving items when adding to a train

Bug-36649-Correctly-embed-biblio-when-retrieving-i.patch (text/plain), 2.26 KB, created by Jonathan Druart on 2024-04-22 12:38:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-04-22 12:38:51 UTC

Size: 2.26 KB

patch

obsolete

>From 21723144b3eeb7257cf0a47188682fcf6f3b3e91 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 22 Apr 2024 14:33:33 +0200
>Subject: [PATCH] Bug 36649: Correctly embed biblio when retrieving items when
> adding to a train
>
>I didn't find when this regression has been introduced but the third
>parameter here is the headers, not parameters, we should not repeat
>"headers".
>
>Test plan:
>1. Add a new processing that contains columns from the database, for example biblio.title and biblio.author.
>2. Create a new train.
>3. Add items to the waiting list.
>4. Click on "Add last x items to the train" button.
>5. Choose the train you created on number 2.
>6. Choose the processing you added on number 1.
>7. Try to click the Submit button.
>=> Without the patch nothing happens and there is a JS error in the
>console: Uncaught TypeError: item.biblio is undefined
>=> With this patch applied the item is correctly added to the train and
>the attribute is properly populated.
>---
> .../components/Preservation/TrainsFormAddItems.vue | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsFormAddItems.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsFormAddItems.vue
>index 7a35d713348..521790581aa 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsFormAddItems.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsFormAddItems.vue
>@@ -167,14 +167,12 @@ export default {
>         async getItems(item_ids) {
>             const client = APIClient.item
>             let q = { "me.item_id": item_ids }
>-            await client.items
>-                .getAll(q, {}, { headers: { "x-koha-embed": "biblio" } })
>-                .then(
>-                    items => {
>-                        this.items = items
>-                    },
>-                    error => {}
>-                )
>+            await client.items.getAll(q, {}, { "x-koha-embed": "biblio" }).then(
>+                items => {
>+                    this.items = items
>+                },
>+                error => {}
>+            )
>         },
>         columnApiMapping(item, db_column) {
>             let table_col = db_column.split(".")
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 36649: 165275 | 165372 | 165376