Bugzilla – Attachment 165324 Details for
Bug 36663
Table configuration options on items table don't show in staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36663: Hide specific inner elements, not the whole top pager container
Bug-36663-Hide-specific-inner-elements-not-the-who.patch (text/plain), 2.45 KB, created by
Pedro Amorim
on 2024-04-22 15:59:43 UTC
(
hide
)
Description:
Bug 36663: Hide specific inner elements, not the whole top pager container
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-04-22 15:59:43 UTC
Size:
2.45 KB
patch
obsolete
>From 6e9b7dc4aa48c378f6e621f39f3fdcbcd0f517ee Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Mon, 22 Apr 2024 15:53:57 +0000 >Subject: [PATCH] Bug 36663: Hide specific inner elements, not the whole top > pager container > >1- Enable StaffDetailItemSelection >2- Visit a biblio page: >http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 >3- Notice there are no table configuration options on the top right (Columns, Export, Configure). >4- Click the "Show filters" link, notice the table configuration options now show, as well as top and bottom pagers, column filter inputs and search input. >5- Disable StaffDetailItemSelection >6- Visit a biblio page: >http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 >7- Notice that the table configurations options are visible, as well as top and bottom pagers, and search input. >8- Click the "Show filters" link, notice it now only governs the column filter inputs, the other elements mentioned in step 7 are always visible. >9- Apply patches, run yarn css:build >10- Repeat 1 and 2. >11- Notice the table configuration options are shown on the top right, and no other table options exist. > >Further testing: >Test clicking hide/show filters >Test with StaffDetailItemSelection enabled/disabled >Test other datatables in other pages >--- > .../includes/html_helpers/tables/items/catalogue_detail.inc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >index 4ce28881209..24f94a7ac4f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >@@ -809,7 +809,9 @@ > if (!add_filters && settings._iRecordsDisplay == settings._iRecordsTotal && settings._iDisplayLength >= settings._iRecordsDisplay){ > let container = $(this).parent(); > container.find(".dt-info").remove(); >- container.find(".top.pager").remove(); >+ container.find(".table_entries").remove(); >+ container.find(".dataTables_filter").remove(); >+ container.find(".dt_button_clear_filter").remove(); > container.find(".bottom.pager").remove(); > } > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36663
:
165262
|
165266
|
165322
|
165323
|
165324
|
165326
|
165327
|
165328
|
165352
|
165353
|
165354