Attachment 165379 Details for Bug 36592 – Bug 36592: Fix default display lenght and default sort

[patch] Bug 36592: Fix default display lenght and default sort

Bug-36592-Fix-default-display-lenght-and-default-s.patch (text/plain), 2.94 KB, created by Pedro Amorim on 2024-04-23 11:36:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-04-23 11:36:18 UTC

Size: 2.94 KB

patch

obsolete

>From 7ab4014ddfe159ba472d58742170e5054babb9ee Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 12 Apr 2024 12:02:46 +0000
>Subject: [PATCH] Bug 36592: Fix default display lenght and default sort
>
>To test:
>1. Go to Admin > Table settings
>2. Find a table that includes Default display length or Default sort
>   order.
>3. Try to save a new value.
>4. When the page reloads the new values have not been saved.
>5. APPLY PATCH
>6. Try 1 -3 again, this time the value should save correctly.
>7. Go to Admin > Table settings and make sure the accordians still work
>   and the in page links in each section still work.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>---
> .../intranet-tmpl/prog/en/modules/admin/columns_settings.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
>index b53ed05053e..efb664fc91e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
>@@ -23,14 +23,14 @@
>                     [% IF tables.$pagename.keys and tables.$pagename.keys.size > 1 %]
>                         Jump to table:
>                         [% FOR tablename IN tables.$pagename.keys.sort %]
>-                            [% SET table_id = pagename _ '_' _ tablename %]
>+                            [% SET table_id = pagename _ '#' _ tablename %]
>                             <a href="#[% table_id | uri %]">[% tablename | html %]</a>
>                             [% UNLESS loop.last %]<span class="separator"> | </span>[% END %]
>                         [% END %]
>                     [% END %]
>                     [% IF tables.$pagename.keys and tables.$pagename.keys.size > 0 %]
>                         [% FOR tablename IN tables.$pagename.keys.sort %]
>-                            [% SET table_id = pagename _ '_' _ tablename %]
>+                            [% SET table_id = pagename _ '#' _ tablename %]
>                             <div class="datatable_config" id="[% table_id | html %]">
>                                 <input type="hidden" name="table_id" value="[% table_id| html %]" />
>                                 [% IF pagename == 'additem' AND tablename == 'itemst' %]
>@@ -385,7 +385,7 @@
>                     $("#[% panel | uri %]_panel").on('shown.bs.collapse', function () {
>                         $('html, body').animate({
>                             [%- IF table.defined -%]
>-                                scrollTop: ($("#[% page | uri %]_[% table | uri %]").offset().top)
>+                                scrollTop: ($("#[% page | uri %]#[% table | uri %]").offset().top)
>                             [%- ELSE -%]
>                                 scrollTop: ($("#[% page | uri %]").offset().top)
>                             [%- END -%]
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36592: 164833 | 164849 | 165379