Bugzilla – Attachment 165402 Details for
Bug 36559
Transport cost matrix update helpers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36559: Add sticky table headers to transport cost matrix
Bug-36559-Add-sticky-table-headers-to-transport-co.patch (text/plain), 2.74 KB, created by
Pedro Amorim
on 2024-04-23 14:01:15 UTC
(
hide
)
Description:
Bug 36559: Add sticky table headers to transport cost matrix
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-04-23 14:01:15 UTC
Size:
2.74 KB
patch
obsolete
>From b2b9d79c1ee9556e18e6001a66acbc1b53151402 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 12 Apr 2024 07:38:23 +0000 >Subject: [PATCH] Bug 36559: Add sticky table headers to transport cost matrix > >To test: >1. APPLY patch and regenerate CSS. ( yarn build ) >2. Have many, many branches. To test it is good to have more branches than in a standard k-t-d. >3. Go to Admin > Transport cost matrix >4. Scroll down and to the right, the table headers should stay visible. >5. Hover over any cell, a title should appear like 'Branch A / Branch B' >6. Test in Chrome and Firefox. > >This uses position: sticky which has recently gained more widespread browser support: >https://caniuse.com/?search=sticky > >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > .../prog/css/src/staff-global.scss | 23 +++++++++++++++++++ > .../en/modules/admin/transport-cost-matrix.tt | 4 ++-- > 2 files changed, 25 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 28beabafc7f..ceb97e4abfd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -4373,6 +4373,29 @@ input.renew { > } > } > >+/* transport cost matrix */ >+#transport-cost-matrix { >+ table { >+ border-collapse: separate; /* Don't collapse */ >+ border-spacing: 0; >+ >+ tbody { >+ tr { >+ th, >+ td { >+ border: 1px solid #dddddd; >+ padding: 5px; >+ } >+ th { >+ position: sticky; >+ top: 0; >+ left: 0; >+ } >+ } >+ } >+ } >+} >+ > /* Permissions */ > > #permissionstree { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt >index b84e41c76e3..688f86dda19 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt >@@ -74,9 +74,9 @@ > </tr> > [% FOR bf IN branchfromloop %] > <tr> >- <th>[% bf.name | html %]</th> >+ <th title="[% bf.name | html %]">[% bf.name | html %]</th> > [% FOR bt IN bf.branchtoloop %] >- <td> >+ <td title="[% bf.name | html %] / [% bt.name | html %]"> > [% IF bt.skip %] > > [% ELSE %] >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36559
:
164794
|
165145
|
165202
|
165203
|
165400
| 165402 |
165403