Bugzilla – Attachment 165454 Details for
Bug 36453
BlockExpiredPatronOpacActions should allow multiple actions options
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36453: (QA follow-up): Update api spec
Bug-36453-QA-follow-up-Update-api-spec.patch (text/plain), 2.30 KB, created by
Pedro Amorim
on 2024-04-24 11:31:01 UTC
(
hide
)
Description:
Bug 36453: (QA follow-up): Update api spec
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-04-24 11:31:01 UTC
Size:
2.30 KB
patch
obsolete
>From 3dd3a4d2b913ed413fbc7109eda2dc0d6f552239 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Wed, 24 Apr 2024 11:25:19 +0000 >Subject: [PATCH] Bug 36453: (QA follow-up): Update api spec > >Access {staff_url}/api/v1/patron_categories and notice all is as expected >Update some patron category's blocked expired patron OPAC actions and access the endpoint again, notice it's okay. > >Updated API tests to include to_api confirming attributes are rendered correctly: >prove t/db_dependent/api/v1/patron_categories >--- > api/v1/swagger/definitions/patron_category.yaml | 4 ++-- > t/db_dependent/api/v1/patron_categories.t | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/api/v1/swagger/definitions/patron_category.yaml b/api/v1/swagger/definitions/patron_category.yaml >index 8d6a361e166..6962be9e6bc 100644 >--- a/api/v1/swagger/definitions/patron_category.yaml >+++ b/api/v1/swagger/definitions/patron_category.yaml >@@ -58,8 +58,8 @@ properties: > type: string > description: Type of Koha patron (Adult, Child, Professional, Organizational, Statistical, Staff) > block_expired_patron_opac_actions: >- type: number >- description: Whether or not a patron of this category can renew books or place holds once their card has expired. 0 means they can, 1 means they cannot, -1 means use syspref BlockExpiredPatronOpacActions >+ type: string >+ description: Specific actions expired patrons of this category are blocked from performing. OPAC actions blocked based on the patron category take priority over this preference > default_privacy: > type: string > enum: >diff --git a/t/db_dependent/api/v1/patron_categories.t b/t/db_dependent/api/v1/patron_categories.t >index 16504569f8d..ecad6041e7c 100755 >--- a/t/db_dependent/api/v1/patron_categories.t >+++ b/t/db_dependent/api/v1/patron_categories.t >@@ -98,7 +98,7 @@ subtest 'list() tests' => sub { > $off_limits_librarian->branchcode( $library->branchcode )->store; > > $t->get_ok("//$off_limits_userid:$off_limits_password@/api/v1/patron_categories?q={\"me.categorycode\":\"TEST\"}") >- ->status_is(200)->json_has('/0/name')->json_is( '/0/name' => 'Test' )->json_hasnt('/1'); >+ ->status_is(200)->json_has('/0/name')->json_is( [ $category->to_api ] )->json_hasnt('/1'); > > $schema->storage->txn_rollback; > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36453
:
164042
|
164043
|
164044
|
164045
|
164046
|
164047
|
164048
|
164762
|
164763
|
164764
|
164765
|
164766
|
164767
|
164768
|
165413
|
165414
|
165454
|
167461
|
167462
|
167463
|
167464
|
167465
|
167466
|
167467
|
167468
|
167469
|
167470
|
167471
|
167472
|
167473
|
167474
|
167475
|
167476
|
167477
|
167478
|
167479
|
167480
|
168435
|
168436