Bugzilla – Attachment 165469 Details for
Bug 36575
Wrong patron can be returned for API validation route
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36575: (bug 34893 follow-up) Return patron from LDAP
Bug-36575-bug-34893-follow-up-Return-patron-from-L.patch (text/plain), 1.49 KB, created by
Nick Clemens (kidclamp)
on 2024-04-24 15:13:48 UTC
(
hide
)
Description:
Bug 36575: (bug 34893 follow-up) Return patron from LDAP
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-04-24 15:13:48 UTC
Size:
1.49 KB
patch
obsolete
>From 8aa28bd9b7fd277739f906ef45cb96f1c97eb2f6 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 24 Apr 2024 14:23:51 +0000 >Subject: [PATCH] Bug 36575: (bug 34893 follow-up) Return patron from LDAP > >--- > C4/Auth_with_ldap.pm | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > >diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm >index 9b8b5d2e57c..f0993c89ba8 100644 >--- a/C4/Auth_with_ldap.pm >+++ b/C4/Auth_with_ldap.pm >@@ -212,12 +212,13 @@ sub checkpw_ldap { > } > > if ($borrowernumber) { >- if ($config{update}) { # A1, B1 >- my $c2 = &update_local($local_userid,$password,$borrowernumber,\%borrower) || ''; >- ($cardnumber eq $c2) or warn "update_local returned cardnumber '$c2' instead of '$cardnumber'"; >- } else { # C1, D1 >- # maybe update just the password? >- return(1, $cardnumber, $local_userid); >+ if ( $config{update} ) { # A1, B1 >+ my $c2 = &update_local( $local_userid, $password, $borrowernumber, \%borrower ) || ''; >+ ( $cardnumber eq $c2 ) or warn "update_local returned cardnumber '$c2' instead of '$cardnumber'"; >+ } else { # C1, D1 >+ # maybe update just the password? >+ my $patron = Koha::Patrons->find($borrowernumber); >+ return ( 1, $cardnumber, $local_userid, $patron ); > } > } elsif ($config{replicate}) { # A2, C2 > my @columns = Koha::Patrons->columns; >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36575
:
164668
|
164670
|
164671
|
165133
|
165134
|
165467
|
165468
|
165469
|
165470
|
165471
|
165908
|
166493
|
166494
|
166495
|
166496
|
166497
|
166498
|
167276
|
167277
|
167278
|
167279
|
167280
|
167281
|
167282
|
167283