Bugzilla – Attachment 165481 Details for
Bug 36684
Cancelling an item with uncertain prices leaves the basket marked as a problem
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36684: Prevent users from cancelling an order if it has uncertain prices
Bug-36684-Prevent-users-from-cancelling-an-order-i.patch (text/plain), 3.90 KB, created by
Laura Escamilla
on 2024-04-24 15:55:00 UTC
(
hide
)
Description:
Bug 36684: Prevent users from cancelling an order if it has uncertain prices
Filename:
MIME Type:
Creator:
Laura Escamilla
Created:
2024-04-24 15:55:00 UTC
Size:
3.90 KB
patch
obsolete
>From 10f21335dbc67c0c55ada399fe26c567613ed131 Mon Sep 17 00:00:00 2001 >From: Laura Escamilla <laura.escamilla@bywatersolutions.com> >Date: Wed, 24 Apr 2024 15:52:05 +0000 >Subject: [PATCH] Bug 36684: Prevent users from cancelling an order if it has > uncertain prices >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To test: >1. Create a basket > 1. Add an item to the basket from an existing record > 1. When adding the item, under accounting details select âUncertain priceâ. Save the item. > 2. Notice that under the RRP tax exc. column the price has an âUncertainâ label. Under the âCancel orderâ column you also have the ability to âCancel orderâ > 3. Cancel the order. A new âCancelled ordersâ table will appear under the âOrdersâ table. The item in the âCancelled ordersâ table is greyed out and does not show any information regarding the âUncertain priceâ label. > 4. The basket remains a âproblemâ basket despite it not having any active items with uncertain prices. >2. Apply the patch and restart_all >3. Create a new basket > 1. Add an item to the basket from an existing record > 1. When adding the item, under accounting details select âUncertain priceâ. Save the item. > 2. Notice that under the RRP tax exc. column the price has an âUncertainâ label. > 3. Under the âCancel orderâ column you now see a message that says, âCanât cancel order because it contains uncertain prices.â > 4. Click on the âUncertain pricesâ tab and uncheck the âUncertainâ box. Save and head back to your basket. > 5. You are now able to âCancel orderâ since the item no longer has an uncertain price. > 2. Add a second item to the basket from an existing record. > 1. Do not select âUncertain priceâ. Save the item. > 2. Under the âCancel orderâ column you have the ability to âCancel orderâ >4. Sign off and have an amazing day! :D >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index fdadf42c66..4cd5c4f82f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -726,7 +726,9 @@ > [% IF ( !closedate || Koha.Preference('CancelOrdersInClosedBaskets') ) %] > <td> > [% IF ( books_loo.orderstatus != "complete") %] >- [% IF ( books_loo.left_holds_on_order ) %] >+ [% IF ( books_loo.uncertainprice ) %] >+ <span class="button" title="Can't cancel order because it contains uncertain prices. Clear uncertain prices first">Can't cancel order because it contains uncertain prices.</span><br> >+ [% ELSIF ( books_loo.left_holds_on_order ) %] > <span class="button" title="Can't cancel order, ([% books_loo.holds_on_order | html %]) holds are linked with this order. Cancel holds first">Can't cancel order</span><br> > [% ELSE %] > <a href="/cgi-bin/koha/acqui/cancelorder.pl?ordernumber=[% books_loo.ordernumber | uri %]&biblionumber=[% books_loo.biblionumber | uri %]&referrer=/cgi-bin/koha/acqui/basket.pl%3Fbasketno=[% basketno | uri %]" class="button">Cancel order</a><br> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36684
: 165481