Bugzilla – Attachment 165519 Details for
Bug 29393
Ability to send emails from patron details page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29393: (QA follow-up) Make database update idempotent
Bug-29393-QA-follow-up-Make-database-update-idempo.patch (text/plain), 1.67 KB, created by
Martin Renvoize
on 2024-04-25 11:01:27 UTC
(
hide
)
Description:
Bug 29393: (QA follow-up) Make database update idempotent
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2024-04-25 11:01:27 UTC
Size:
1.67 KB
patch
obsolete
>From b46ce7ab5ed02cd7f64a34063765f52ac29e4543 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 25 Apr 2024 09:58:19 +0100 >Subject: [PATCH] Bug 29393: (QA follow-up) Make database update idempotent > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../Bug_29393_add_send_message_permission.pl | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > mode change 100644 => 100755 installer/data/mysql/atomicupdate/Bug_29393_add_send_message_permission.pl > >diff --git a/installer/data/mysql/atomicupdate/Bug_29393_add_send_message_permission.pl b/installer/data/mysql/atomicupdate/Bug_29393_add_send_message_permission.pl >old mode 100644 >new mode 100755 >index 12327f92bed..1d8fe41c9d1 >--- a/installer/data/mysql/atomicupdate/Bug_29393_add_send_message_permission.pl >+++ b/installer/data/mysql/atomicupdate/Bug_29393_add_send_message_permission.pl >@@ -1,14 +1,16 @@ > use Modern::Perl; > > return { >- bug_number => "29393", >+ bug_number => "29393", > description => "Add permission borrowers:send_messages_to_borrowers", >- up => sub { >+ up => sub { > my ($args) = @_; >- my ($dbh, $out) = @$args{qw(dbh out)}; >+ my ( $dbh, $out ) = @$args{qw(dbh out)}; > >- $dbh->do(q{INSERT INTO permissions (module_bit, code, description) >- VALUES (4, 'send_messages_to_borrowers', 'Send messages to patrons')}); >+ $dbh->do( >+ q{INSERT IGNORE INTO permissions (module_bit, code, description) >+ VALUES (4, 'send_messages_to_borrowers', 'Send messages to patrons')} >+ ); > say $out "Update is going well so far"; > }, >-} >+ } >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29393
:
127237
|
127238
|
127452
|
127506
|
127511
|
127847
|
128215
|
128216
|
128217
|
128218
|
128219
|
128363
|
148187
|
148188
|
148189
|
148190
|
148191
|
148192
|
148193
|
148194
|
149812
|
160107
|
160108
|
160109
|
160110
|
160111
|
160112
|
160113
|
160114
|
160633
|
160638
|
160639
|
165498
|
165499
|
165500
|
165501
|
165502
|
165503
|
165504
|
165505
|
165511
|
165512
|
165513
|
165514
|
165515
|
165516
|
165517
|
165518
| 165519 |
165520
|
165521
|
165522
|
165942