Attachment 165588 Details for Bug 36701 – Bug 36701: Adjust confirmation to hide empty div

[patch] Bug 36701: Adjust confirmation to hide empty div

Bug-36701-Adjust-confirmation-to-hide-empty-div.patch (text/plain), 2.56 KB, created by Lucas Gass (lukeg) on 2024-04-25 20:04:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-04-25 20:04:09 UTC

Size: 2.56 KB

patch

obsolete

>From 05c26e3720e72061f06281d18ea675025667e1e9 Mon Sep 17 00:00:00 2001
>From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Date: Thu, 25 Apr 2024 14:58:31 -0400
>Subject: [PATCH] Bug 36701: Adjust confirmation to hide empty div
>
>To test:
>1. Place a hold on any bib record
>2. Cancel the hold by clicking the trash can icon next to it
>--> Note that there is an empty red page section in the modal
>3. Apply patch and refresh the page
>4. Repeat steps 1-2
>--> No empty red page section
>5. Confirm that the test plan from bug 33174 still works
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 11d6d34c81..02762da4ed 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -1280,7 +1280,7 @@
> 
>                 <div class="modal-body">
>                     <p>Are you sure you want to cancel this hold?</p>
>-                    <div id="cancel_hold_alert" class="alert alert-danger"></div>
>+                    <div id="cancel_hold_alert" class="alert alert-danger" style="display:none;"></div>
>                     <fieldset class="action">
>                         [% SET hold_cancellation = AuthorisedValues.GetAuthValueDropbox('HOLD_CANCELLATION') %]
>                         [% IF hold_cancellation.count %]
>@@ -1728,6 +1728,7 @@
>                 $(this).prop('checked', !count);
>                 $('.cancel_selected_holds').html(MSG_CANCEL_SELECTED.format($('.holds_table .select_hold:checked').length));
>                 $('#cancel_hold_alert').html( MSG_CANCEL_ALERT.format($('.holds_table .select_hold:checked').length));
>+                $('#cancel_hold_alert').show();
>                 localStorage.selectedHolds = $('.holds_table .select_hold:checked').toArray().map(el => $(el).data('id'));
>             });
> 
>@@ -1737,6 +1738,7 @@
>                 $('.select_hold_all', table).prop('checked', !count);
>                 $('.cancel_selected_holds').html(MSG_CANCEL_SELECTED.format($('.holds_table .select_hold:checked').length));
>                 $('#cancel_hold_alert').html( MSG_CANCEL_ALERT.format($('.holds_table .select_hold:checked').length));
>+                $('#cancel_hold_alert').show();
>                 localStorage.selectedHolds = $('.holds_table .select_hold:checked').toArray().map(el => $(el).data('id'));
>             });
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36701: 165580 | 165583 | 165588