Bugzilla – Attachment 165610 Details for
Bug 35362
Update patron module pop-up windows with consistent footer markup
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35362: (follow-up) Fix guaruntor preview modal close in test
Bug-35362-follow-up-Fix-guaruntor-preview-modal-cl.patch (text/plain), 1.96 KB, created by
Martin Renvoize (ashimema)
on 2024-04-26 07:13:38 UTC
(
hide
)
Description:
Bug 35362: (follow-up) Fix guaruntor preview modal close in test
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-04-26 07:13:38 UTC
Size:
1.96 KB
patch
obsolete
>From 785fb2956de8b8ecae61fe3288bd765880c4c9e6 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 26 Apr 2024 08:12:05 +0100 >Subject: [PATCH] Bug 35362: (follow-up) Fix guaruntor preview modal close in > test > >This patch updates the selenium test to correct the selector used to >close the preview modal as it changed with this patchset. >--- > t/db_dependent/selenium/patrons_search.t | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/selenium/patrons_search.t b/t/db_dependent/selenium/patrons_search.t >index 43d0ff9e8c3..da2318d1c2d 100755 >--- a/t/db_dependent/selenium/patrons_search.t >+++ b/t/db_dependent/selenium/patrons_search.t >@@ -501,11 +501,13 @@ subtest 'Search patrons in modal' => sub { > sprintf( > "%s %s %s (%s)", $patron->title, $patron->firstname, > $patron->surname, $patron->cardnumber >- ) >+ ), >+ 'Patron preview modal has correct content' > ); > > # Close the patron preview modal >- $driver->find_element('//div[@id="patron_preview_modal"]//input[@class="close"]')->click; >+ $driver->find_element('//*[@id="patron_preview_modal"]/div[2]/fieldset/button')->click; >+ > $s->wait_for_element_hidden('//div[@id="patron_preview_modal"]'); > > # Select patron 2 >@@ -520,7 +522,8 @@ subtest 'Search patrons in modal' => sub { > # => The guarantor block has the info of the selected patron > is( > $driver->find_element('//a[@class="new_guarantor_link"]')->get_text(), >- sprintf( "%s %s (%s)", $patron->firstname, $patron->surname, $patron->cardnumber ) >+ sprintf( "%s %s (%s)", $patron->firstname, $patron->surname, $patron->cardnumber ), >+ 'Guarantor block contains info of selected patron' > ); > is( > $driver->find_element('//input[@class="new_guarantor_id noEnterSubmit"]')->get_value(), >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35362
:
159096
|
159118
|
162390
|
165609
| 165610 |
166682