Bugzilla – Attachment 165652 Details for
Bug 36676
SIP2 drops connection when using unknown patron id in fee paid message
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
BUG 36676: SIP2 drops connection on unknown patron id in fee paid message
BUG-36676-SIP2-drops-connection-on-unknown-patron-.patch (text/plain), 1.78 KB, created by
Jan Kissig
on 2024-04-26 12:40:03 UTC
(
hide
)
Description:
BUG 36676: SIP2 drops connection on unknown patron id in fee paid message
Filename:
MIME Type:
Creator:
Jan Kissig
Created:
2024-04-26 12:40:03 UTC
Size:
1.78 KB
patch
obsolete
>From 27cb259ce0c476a77c53b964fddd3465077a9214 Mon Sep 17 00:00:00 2001 >From: Jan Kissig <jkissig@th-wildau.de> >Date: Tue, 23 Apr 2024 20:19:05 +0200 >Subject: [PATCH] BUG 36676: SIP2 drops connection on unknown patron id in fee > paid message > >When sending a fee paid message to SIP2 with an unknown patron id it will respond with an empty response followed by dropping the connection to a client. > >to test on ktd (23.11): >a) perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 2352900100046 -m fee_paid --fee-type FT --fee-amount 0.01 >Output: >Trying 'fee_paid' >SEND: 3720240423 124447FT00USDBV0.01|AO|AA2352900100046|ACterm1| >Use of uninitialized value $data in concatenation (.) or string at /usr/share/koha/bin/sip_cli_emulator.pl line 355, <GEN0> chunk 1. >READ: > >b) apply patch >c) perl /usr/share/koha/bin/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 2352900100046 -m fee_paid --fee-type FT --fee-amount 0.01 >Output: >Trying 'fee_paid' >SEND: 3720240423 125602FT00USDBV0.01|AO|AA2352900100046|ACterm1| >READ: 38N20240423 125602AO|AA2352900100046|AFInvalid patron barcode.| >--- > C4/SIP/ILS.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm >index 2184f13e1b..3e77abf602 100644 >--- a/C4/SIP/ILS.pm >+++ b/C4/SIP/ILS.pm >@@ -324,7 +324,9 @@ sub pay_fee { > $trans->patron($patron = C4::SIP::ILS::Patron->new($patron_id)); > if (!$patron) { > $trans->screen_msg('Invalid patron barcode.'); >- return $trans; >+ return { >+ status => $trans >+ }; > } > my $trans_result = $trans->pay( $patron->{borrowernumber}, $fee_amt, $pay_type, $fee_id, $is_writeoff, $disallow_overpayment, $register_id ); > my $ok = $trans_result->{ok}; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36676
:
165436
|
165652
|
165653
|
166182
|
166530