Attachment 165749 Details for Bug 36708 – Bug 36708: Fix column index for processing No automatic renewal after

[patch] Bug 36708: Fix column index for processing No automatic renewal after

Bug-36708-Fix-column-index-for-processing-No-autom.patch (text/plain), 1.88 KB, created by Lucas Gass (lukeg) on 2024-04-29 15:20:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-04-29 15:20:35 UTC

Size: 1.88 KB

patch

obsolete

>From 60d06d3ac976fc06fcbad6eb2f3151423b26665e Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Mon, 29 Apr 2024 15:18:26 +0000
>Subject: [PATCH] Bug 36708: Fix column index for processing No automatic
> renewal after
>
>To test:
>1- Find or create a circulation rule with a 'Holds allowed (total)' limit of 3 (or another number) and no value in 'No automatic renewal after (hard limit)'
>2- Select to edit the rule, and note that 'No automatic renewal after (hard limit)' box in the editing line is now populated with a date
>3- Note also that 'Holds allowed (total)' is empty in your editing line
>4- If you save your edits without clearing the new 'No automatic renewal after (hard limit)' date, it will save as part of the rule. Also, 'Holds allowed (total)' will save as Unlimited unless you re-add your numerical value.
>5- APPLY PATCH
>6- Try again, the values should save corrected and not erroneously fill the No automatic renewal after (hard limit) column.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index 1109b0e99c..0004376ec1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -1516,7 +1516,7 @@
>                             hardduedate = fp.parseDate( hardduedate, flatpickr_dateformat_string );
>                             if( hardduedate) fp.setDate( hardduedate, 1 );
>                         }
>-                    } else if ( i == 26 ) {
>+                    } else if ( i == 25 ) {
>                         // specific processing for No automatic renewal after (hard limit)
>                         var renewdate = itm_text;
>                         if (renewdate) {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36708: 165749 | 166232 | 166622