Attachment 165756 Details for Bug 36694 – Bug 36694: Remove HC sticky from patron search searchbar

[patch] Bug 36694: Remove HC sticky from patron search searchbar

Bug-36694-Remove-HC-sticky-from-patron-search-sear.patch (text/plain), 4.73 KB, created by Lucas Gass (lukeg) on 2024-04-29 17:03:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-04-29 17:03:47 UTC

Size: 4.73 KB

patch

obsolete

>From d3d27284c407c9a977301934f95997be859ee223 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Wed, 24 Apr 2024 22:30:33 +0000
>Subject: [PATCH] Bug 36694: Remove HC sticky from patron search searchbar
>
>---
> .../intranet-tmpl/prog/css/src/staff-global.scss  |  3 +++
> .../prog/en/includes/patron-search.inc            | 15 ---------------
> .../prog/en/modules/members/member.tt             |  2 +-
> 3 files changed, 4 insertions(+), 16 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index 121030e70f..c42e367d21 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -2059,6 +2059,9 @@ li {
> }
> 
> .searchheader {
>+    position: sticky;
>+    top: 0;
>+    z-index: 999;
>     background-color: #F3F4F4;
>     box-shadow: 0 0 2px 1px rgba( 0, 0, 0, .2 );
>     color: #696969;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>index 6dd9d150fa..cce12b3534 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>@@ -212,7 +212,6 @@
> [%# columns: list of columns that will be displayed. Possible values are: 'checkbox', 'cardnumber', 'dateofbirth', 'address', 'name', 'name-address', 'branch', 'category', 'dateexpiry', 'borrowernotes, 'phone', 'checkouts', 'account_balance', 'action' %]
> [%# preview_on_name_click: Open a modal window with patron's info when the name is clicked %]
> [%# actions: list of buttons to display in the action column. Possible values are: 'select', 'add', 'edit', 'checkout' %]
>-[%# sticky_header and sticky_to: If we need a sticky header %]
> [%# callback: name of the JS function that will be called when a patron is selected. Only work with action=select %]
> [%# display_search_description: boolean, default off. Display the description of the search %]
> [%# adjust_history: boolean, default off. Change the current url when a first letter is selected %]
>@@ -266,9 +265,6 @@
>     [% INCLUDE 'js-patron-get-age.inc' %]
>     [% INCLUDE 'js-patron-format.inc' %]
>     [% INCLUDE 'js-patron-format-address.inc' %]
>-    [% IF sticky_header %]
>-        [% Asset.js("lib/hc-sticky/hc-sticky.js") | $raw %]
>-    [% END %]
> 
>     <script>
>     {
>@@ -281,7 +277,6 @@
>         }
>         let first_draw = 0;
>         let patrons_table;
>-        let Sticky;
>         let singleBranchMode = '[% singleBranchMode | html %]';
>         let logged_in_library_id = "[% Branches.GetLoggedInBranchcode | html %]";
>         let defer_loading = Number( '[% defer_loading | html %]' || 1 );
>@@ -655,16 +650,6 @@
>                 'lengthMenu': [aLengthMenu, aLengthMenuLabel],
>                 "pagingType": 'full_numbers',
>                 "pageLength": [% Koha.Preference('PatronsPerPage') | html %],
>-                [% IF sticky_header %]
>-                "initComplete": function(settings, json) {
>-                    $("#[% sticky_header | html %]").show();
>-                    Sticky = $("#[% sticky_header | html %]");
>-                    Sticky.hcSticky({
>-                        stickTo: "#[% sticky_to | html %]",
>-                        stickyClass: "floating"
>-                    });
>-                },
>-                [% END %]
>                 fixedHeader: false,
>             }, typeof table_settings !== 'undefined' ? table_settings : null, 1, additional_filters);
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>index 7bc63c9e72..34ca689a36 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>@@ -347,7 +347,7 @@
>     [% ELSE %]
>         [% SET redirect_url = '/cgi-bin/koha/members/moremember.pl' %]
>     [% END %]
>-    [% PROCESS patron_search_js defer_loading => defer_loading, table_id => 'memberresultst', categories => categories, libraries => libraries, columns => columns,actions => ['edit', 'checkout'], redirect_if_one_result => 1, redirect_url => redirect_url, sticky_header => "searchheader", sticky_to => "searchresults", default_sort_column => 'name-address', display_search_description => 1, remember_selections => 1, adjust_history => 1 %]
>+    [% PROCESS patron_search_js defer_loading => defer_loading, table_id => 'memberresultst', categories => categories, libraries => libraries, columns => columns,actions => ['edit', 'checkout'], redirect_if_one_result => 1, redirect_url => redirect_url, default_sort_column => 'name-address', display_search_description => 1, remember_selections => 1, adjust_history => 1 %]
> 
> [% END %]
> [% INCLUDE 'intranet-bottom.inc' %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36694: 165489 | 165490 | 165491 | 165492 | 165493 | 165576 | 165582 | 165584 | 165587 | 165680 | 165682 | 165683 | 165684 | 165686 | 165756 | 165757 | 165758 | 165759 | 165760 | 165761 | 165762 | 165763 | 165764 | 165765 | 165766 | 165767 | 166703 | 166704 | 166705 | 166706 | 166707 | 166708 | 166709 | 166710 | 166711 | 166712 | 166713 | 166714 | 166715 | 166940 | 167507 | 167508 | 167509 | 167510 | 167511 | 167512 | 167513 | 167514 | 167515 | 167516 | 167517 | 167518 | 167519 | 167520 | 167539 | 167823 | 167824 | 167825 | 167826 | 167827 | 167828 | 167829 | 167830 | 167831 | 167832 | 167833 | 167834 | 167835 | 167836 | 167837 | 169110 | 169111 | 169112 | 169113 | 169114 | 169115 | 169116 | 169117 | 169118 | 169119 | 169120 | 169121 | 169122 | 169123 | 169124 | 169125 | 171080 | 171081 | 171082 | 171083 | 171084 | 171085 | 171086 | 171087 | 171088 | 171089 | 171090 | 171091 | 171092 | 171093 | 171094 | 171095 | 171852 | 171853 | 171854 | 171855 | 171856 | 171857 | 171858 | 171859 | 171860 | 171861 | 171862 | 171863 | 171864 | 171865 | 171866 | 171867