Bugzilla – Attachment 165802 Details for
Bug 32565
Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32565: (QA follow-up) Fix tests
Bug-32565-QA-follow-up-Fix-tests.patch (text/plain), 2.36 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-04-29 18:46:01 UTC
(
hide
)
Description:
Bug 32565: (QA follow-up) Fix tests
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-04-29 18:46:01 UTC
Size:
2.36 KB
patch
obsolete
>From f802ce4cfc21f84112347b8bde296c708fff3d8d Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Mon, 19 Feb 2024 10:45:50 +0000 >Subject: [PATCH] Bug 32565: (QA follow-up) Fix tests > >Apply original tests patch + this follow-up. Run: >prove t/db_dependent/HoldsQueue.t >Notice tests fail. >Apply fix patch, run the above prove command again. >Notice tests pass. > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > t/db_dependent/HoldsQueue.t | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > >diff --git a/t/db_dependent/HoldsQueue.t b/t/db_dependent/HoldsQueue.t >index 531f9edb80a..987aba21ee3 100755 >--- a/t/db_dependent/HoldsQueue.t >+++ b/t/db_dependent/HoldsQueue.t >@@ -2252,19 +2252,20 @@ subtest "Test unallocated option" => sub { > "Picked the item" > ); > >- my $timestamp = $hold->timestamp; >+ my $original_timestamp = $hold->timestamp; > >- sleep 2; >+ sleep 2; # Allow time to pass after first hold was placed > C4::HoldsQueue::CreateQueue(); > $queue_rs = $schema->resultset('TmpHoldsqueue')->search( { biblionumber => $item1->biblionumber } ); > $hold = $queue_rs->next; >- isnt( $hold->timestamp, $timestamp, "Hold was reallocated when queue fully rebuilt" ); >- $timestamp = $hold->timestamp; >+ isnt( $hold->timestamp, $original_timestamp, "Hold was reallocated when queue fully rebuilt" ); >+ my $after_rebuild_timestamp = $hold->timestamp; > >+ sleep 2; # Allow time to pass after first full rebuild > C4::HoldsQueue::CreateQueue( { unallocated => 1 } ); > $queue_rs = $schema->resultset('TmpHoldsqueue')->search( { biblionumber => $item1->biblionumber } ); > $hold = $queue_rs->next; >- is( $hold->timestamp, $timestamp, "Previously allocated hold not updated when unallocated passed" ); >+ is( $hold->timestamp, $after_rebuild_timestamp, "Previously allocated hold not updated when unallocated passed" ); > > my $reserve_id_2 = AddReserve( > { >@@ -2285,7 +2286,7 @@ subtest "Test unallocated option" => sub { > $queue_rs = $schema->resultset('TmpHoldsqueue')->search( { biblionumber => $item1->biblionumber } ); > $hold = $queue_rs->next; > is( >- $hold->timestamp, $timestamp, >+ $hold->timestamp, $after_rebuild_timestamp, > "Previously allocated hold not updated when unallocated passed and others are allocated" > ); > }; >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32565
:
147659
|
161231
|
161232
|
161393
|
161394
|
161679
|
161680
|
162269
|
162297
|
164272
|
164273
|
164274
|
165166
|
165167
|
165168
|
165169
|
165800
|
165801
| 165802 |
165803