Bugzilla – Attachment 165817 Details for
Bug 35138
Enable configuration of facets with Elasticsearch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35138: Fix Koha_Elasticsearch.t
Bug-35138-Fix-KohaElasticsearcht.patch (text/plain), 1.60 KB, created by
Jonathan Druart
on 2024-04-29 21:07:14 UTC
(
hide
)
Description:
Bug 35138: Fix Koha_Elasticsearch.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-04-29 21:07:14 UTC
Size:
1.60 KB
patch
obsolete
>From c511fd72a83879640841a27e60973258cbf2544f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 29 Apr 2024 23:06:17 +0200 >Subject: [PATCH] Bug 35138: Fix Koha_Elasticsearch.t > >--- > t/db_dependent/Koha_Elasticsearch.t | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > >diff --git a/t/db_dependent/Koha_Elasticsearch.t b/t/db_dependent/Koha_Elasticsearch.t >index 078d55d6594..63402d7ccc3 100755 >--- a/t/db_dependent/Koha_Elasticsearch.t >+++ b/t/db_dependent/Koha_Elasticsearch.t >@@ -28,9 +28,9 @@ use Koha::SearchEngine::Elasticsearch; > my $schema = Koha::Database->schema; > my $builder = t::lib::TestBuilder->new; > >-subtest 'get_facetable_fields() tests' => sub { >+subtest 'get_facet_fields() tests' => sub { > >- plan tests => 15; >+ plan tests => 13; > > $schema->storage->txn_begin; > >@@ -109,8 +109,8 @@ subtest 'get_facetable_fields() tests' => sub { > } > }); > >- my @faceted_fields = Koha::SearchEngine::Elasticsearch->get_facetable_fields(); >- is(scalar(@faceted_fields), 7); >+ my @faceted_fields = Koha::SearchEngine::Elasticsearch->get_facet_fields(); >+ is(scalar(@faceted_fields), 6); > > is($faceted_fields[0]->name, 'holdingbranch'); > is($faceted_fields[0]->facet_order, 1); >@@ -124,9 +124,6 @@ subtest 'get_facetable_fields() tests' => sub { > is($faceted_fields[4]->facet_order, 5); > is($faceted_fields[5]->name, 'subject'); > is($faceted_fields[5]->facet_order, 6); >- is($faceted_fields[6]->name, 'author'); >- ok(!$faceted_fields[6]->facet_order); >- > > $schema->storage->txn_rollback; > }; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35138
:
163133
|
163680
|
163681
|
163682
|
163683
|
163684
|
163896
|
163897
|
163898
|
163899
|
163900
|
164811
|
164812
|
164813
|
164814
|
164815
|
164816
|
165811
|
165812
|
165813
|
165814
|
165815
|
165816
| 165817 |
165818
|
166402