Bugzilla – Attachment 165842 Details for
Bug 36137
update_totalissues.pl should always skip_holds_queue
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36137: Make update_totalissues cron always skip the holds queue
Bug-36137-Make-updatetotalissues-cron-always-skip-.patch (text/plain), 1.88 KB, created by
Matt Blenkinsop
on 2024-04-30 11:11:19 UTC
(
hide
)
Description:
Bug 36137: Make update_totalissues cron always skip the holds queue
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2024-04-30 11:11:19 UTC
Size:
1.88 KB
patch
obsolete
>From b9a6f52da8743e5e39fafc55cb66b10e3eeba0c5 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 10 Apr 2024 11:56:01 +0000 >Subject: [PATCH] Bug 36137: Make update_totalissues cron always skip the holds > queue > >To test: >1. Run the update_totalissues cron, the holds queue is updated. >2. APPLY PATCH, restart services >3. Run update_totalissues cron again, this time the holds queue should always be skipped. > >Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >--- > C4/Biblio.pm | 2 ++ > misc/cronjobs/update_totalissues.pl | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 5f1f456999..4b32ad43d5 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -3077,6 +3077,8 @@ Update the total issue count for a particular bib record. > > =item C<$value> is the absolute value that total issues count should be set to. If provided, C<$increase> is ignored. > >+=item C<$skip_holds_queue> parameter to optionally skip updating the holds queue. >+ > =back > > =cut >diff --git a/misc/cronjobs/update_totalissues.pl b/misc/cronjobs/update_totalissues.pl >index eee8fdef62..3e3a66b1f2 100755 >--- a/misc/cronjobs/update_totalissues.pl >+++ b/misc/cronjobs/update_totalissues.pl >@@ -168,10 +168,10 @@ sub process_query { > if ( not $test_only ) { > my $ret; > if ( $incremental && $totalissues > 0 ) { >- $ret = UpdateTotalIssues( $biblionumber, $totalissues ); >+ $ret = UpdateTotalIssues( $biblionumber, $totalissues, undef, 1 ); > } > else { >- $ret = UpdateTotalIssues( $biblionumber, 0, $totalissues ); >+ $ret = UpdateTotalIssues( $biblionumber, 0, $totalissues, 1 ); > } > unless ($ret) { > print "Error while processing bib $biblionumber\n" if $verbose; >-- >2.37.1 (Apple Git-137.1)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36137
:
162301
|
163766
|
164610
|
165842
|
166142