Bugzilla – Attachment 165844 Details for
Bug 28762
Item status shows incorrectly on course-details.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28762: handle notforloan better
Bug-28762-handle-notforloan-better.patch (text/plain), 2.08 KB, created by
Martin Renvoize (ashimema)
on 2024-04-30 11:14:07 UTC
(
hide
)
Description:
Bug 28762: handle notforloan better
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-04-30 11:14:07 UTC
Size:
2.08 KB
patch
obsolete
>From 3d1a83053c6a9aaf8d5c96205d52387f7bd05e18 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 27 Jul 2021 21:45:12 +0000 >Subject: [PATCH] Bug 28762: handle notforloan better > >Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../intranet-tmpl/prog/css/src/staff-global.scss | 3 ++- > .../intranet-tmpl/prog/en/includes/item-status.inc | 11 ++++------- > 2 files changed, 6 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 181554d19da..62ebc2462c7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -2286,7 +2286,8 @@ td { > .restricted, > .damaged, > .lost, >-.withdrawn { >+.withdrawn, >+.notforloan { > color: #990000; > display: block; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/item-status.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/item-status.inc >index 7da27283f62..f5e5dfe45ce 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/item-status.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/item-status.inc >@@ -62,17 +62,14 @@ > [% END %] > [% END %] > >- >-[% IF NOT ( item.isa('Koha::Item') ) AND item.itemnotforloan %] >+[% IF ( item.notforloan ) %] > [% SET itemavailable = 0 %] >- [% IF ( item.notforloanvalueopac ) %] >- <span class="item-status notforloan">[% item.notforloanvalueopac | html %]</span> >+ [% av_lib_include = AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.notforloan', authorised_value => item.notforloan ) %] >+ [% IF av_lib_include %] >+ <span class="item-status notforloan">[% av_lib_include | html %]</span> > [% ELSE %] > <span class="item-status notforloan">Not for loan</span> > [% END %] >-[% ELSIF NOT ( item.isa('Koha::Item') ) AND item.notforloan_per_itemtype %] >- [% SET itemavailable = 0 %] >- <span class="item-status notforloan">Not for loan</span> > [% END %] > > [% IF ( item.damaged ) %] >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28762
:
123233
|
123234
|
123236
|
123237
|
124661
|
124666
|
124667
|
124668
|
124744
|
125220
|
125228
|
125229
|
125233
|
161563
|
161564
|
161565
|
161566
|
161567
|
161568
|
161569
|
161570
|
161571
|
161572
|
161573
|
161574
|
161584
|
161585
|
161586
|
161587
|
161588
|
161589
|
161590
|
161591
|
163310
|
163311
|
163312
|
163313
|
163314
|
163315
|
163316
|
163317
|
165843
|
165844
|
165845
|
165846
|
165847
|
165848
|
165849
|
165850
|
169172
|
169273
|
169274
|
169275
|
169276
|
169277
|
169278
|
169279
|
169280
|
169281
|
169311
|
169312
|
169313
|
169314
|
169354
|
169355
|
169356
|
169357
|
169358
|
169359
|
169360
|
169361
|
169362
|
169363
|
169364
|
169365
|
169366
|
169367
|
169393