Bugzilla – Attachment 165864 Details for
Bug 32610
Add ability to specify patron attribute as a date
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32610: (QA follow-up) Tidy exceptions file
Bug-32610-QA-follow-up-Tidy-exceptions-file.patch (text/plain), 3.38 KB, created by
Martin Renvoize (ashimema)
on 2024-04-30 11:56:27 UTC
(
hide
)
Description:
Bug 32610: (QA follow-up) Tidy exceptions file
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-04-30 11:56:27 UTC
Size:
3.38 KB
patch
obsolete
>From e2117f56951e4910555a86296872eb0bb5e1804b Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 30 Apr 2024 12:48:47 +0100 >Subject: [PATCH] Bug 32610: (QA follow-up) Tidy exceptions file > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Exceptions/Patron/Attribute.pm | 21 +++++++++------------ > 1 file changed, 9 insertions(+), 12 deletions(-) > >diff --git a/Koha/Exceptions/Patron/Attribute.pm b/Koha/Exceptions/Patron/Attribute.pm >index 145f0008c79..f513d093bfd 100644 >--- a/Koha/Exceptions/Patron/Attribute.pm >+++ b/Koha/Exceptions/Patron/Attribute.pm >@@ -12,22 +12,22 @@ use Exception::Class ( > 'Koha::Exceptions::Patron::Attribute::InvalidType' => { > isa => 'Koha::Exceptions::Patron::Attribute', > description => "the passed type is invalid", >- fields => [ "type" ] >+ fields => ["type"] > }, > 'Koha::Exceptions::Patron::Attribute::NonRepeatable' => { > isa => 'Koha::Exceptions::Patron::Attribute', > description => "repeatable not set for attribute type and tried to add a new attribute for the same code", >- fields => [ "attribute" ] >+ fields => ["attribute"] > }, > 'Koha::Exceptions::Patron::Attribute::UniqueIDConstraint' => { > isa => 'Koha::Exceptions::Patron::Attribute', > description => "unique_id set for attribute type and tried to add a new with the same code and value", >- fields => [ "attribute" ] >+ fields => ["attribute"] > }, > 'Koha::Exceptions::Patron::Attribute::InvalidAttributeValue' => { >- isa => 'Koha::Exceptions::Patron::Attribute', >+ isa => 'Koha::Exceptions::Patron::Attribute', > description => "the passed value is invalid for attribute type", >- fields => [ "attribute" ] >+ fields => ["attribute"] > } > ); > >@@ -36,28 +36,25 @@ sub full_message { > > my $msg = $self->message; > >- unless ( $msg) { >+ unless ($msg) { > if ( $self->isa('Koha::Exceptions::Patron::Attribute::NonRepeatable') ) { > $msg = sprintf( > "Tried to add more than one non-repeatable attributes. type=%s value=%s", > $self->attribute->code, > $self->attribute->attribute > ); >- } >- elsif ( $self->isa('Koha::Exceptions::Patron::Attribute::UniqueIDConstraint') ) { >+ } elsif ( $self->isa('Koha::Exceptions::Patron::Attribute::UniqueIDConstraint') ) { > $msg = sprintf( > "Your action breaks a unique constraint on the attribute. type=%s value=%s", > $self->attribute->code, > $self->attribute->attribute > ); >- } >- elsif ( $self->isa('Koha::Exceptions::Patron::Attribute::InvalidType') ) { >+ } elsif ( $self->isa('Koha::Exceptions::Patron::Attribute::InvalidType') ) { > $msg = sprintf( > "Tried to use an invalid attribute type. type=%s", > $self->type > ); >- } >- elsif ( $self->isa('Koha::Exceptions::Patron::Attribute::InvalidAttributeValue') ) { >+ } elsif ( $self->isa('Koha::Exceptions::Patron::Attribute::InvalidAttributeValue') ) { > $msg = sprintf( > "Tried to use an invalid value for attribute type. type=%s value=%s", > $self->attribute->code, >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32610
:
148400
|
148401
|
148402
|
148403
|
148404
|
148405
|
148825
|
148826
|
148827
|
148828
|
148829
|
148830
|
157862
|
157863
|
157864
|
157865
|
157866
|
157867
|
157868
|
158994
|
158995
|
158996
|
158997
|
158998
|
158999
|
159000
|
165747
|
165750
|
165854
|
165855
|
165856
|
165857
|
165858
|
165859
|
165860
|
165861
|
165862
|
165863
| 165864 |
165865
|
165925
|
165926