Bugzilla – Attachment 165908 Details for
Bug 36575
Wrong patron can be returned for API validation route
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36575: (QA follow-up) Shibboleth POD and checkpw_internal call
Bug-36575-QA-follow-up-Shibboleth-POD-and-checkpwi.patch (text/plain), 1.45 KB, created by
Marcel de Rooy
on 2024-04-30 14:48:17 UTC
(
hide
)
Description:
Bug 36575: (QA follow-up) Shibboleth POD and checkpw_internal call
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-04-30 14:48:17 UTC
Size:
1.45 KB
patch
obsolete
>From 98ecf1797cf1b27fcf828a1c9a92e95a113f97cd Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 30 Apr 2024 14:39:36 +0000 >Subject: [PATCH] Bug 36575: (QA follow-up) Shibboleth POD and checkpw_internal > call >Content-Type: text/plain; charset=utf-8 > >--- > C4/Auth.pm | 4 ++-- > C4/Auth_with_shibboleth.pm | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index f10e815523..b7ecafa804 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -2026,8 +2026,8 @@ sub checkpw { > > # INTERNAL AUTH > @return = checkpw_internal( $userid, $password, $no_set_userenv ); >- $passwd_ok = 1 if $return[0] > 0; # 1 or 2 >- $patron = $return[3]; >+ $passwd_ok = $return[0]; >+ $patron = $passwd_ok ? $return[3] : undef; > } > > if ( defined $userid && !$patron ) { >diff --git a/C4/Auth_with_shibboleth.pm b/C4/Auth_with_shibboleth.pm >index f9ba592b3e..3e6f42b57c 100644 >--- a/C4/Auth_with_shibboleth.pm >+++ b/C4/Auth_with_shibboleth.pm >@@ -409,7 +409,7 @@ This routine is NOT exported > > =head2 _autocreate > >- my ( $retval, $retcard, $retuserid ) = _autocreate( $config, $match ); >+ my ( $retval, $retcard, $retuserid, $patron ) = _autocreate( $config, $match, $patron ); > > Given a shibboleth attribute reference and a userid this internal routine will add the given user to Koha and return their user credentials. > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36575
:
164668
|
164670
|
164671
|
165133
|
165134
|
165467
|
165468
|
165469
|
165470
|
165471
|
165908
|
166493
|
166494
|
166495
|
166496
|
166497
|
166498
|
167276
|
167277
|
167278
|
167279
|
167280
|
167281
|
167282
|
167283