Bugzilla – Attachment 165955 Details for
Bug 36555
Add report_id to file name when exporting report results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36555: (QA follow-up) Tidy
Bug-36555-QA-follow-up-Tidy.patch (text/plain), 1.88 KB, created by
Nick Clemens (kidclamp)
on 2024-05-01 10:34:28 UTC
(
hide
)
Description:
Bug 36555: (QA follow-up) Tidy
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-05-01 10:34:28 UTC
Size:
1.88 KB
patch
obsolete
>From bb8ba58ab2c588ece61c6efcdf01fede1257ec51 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 1 May 2024 10:33:43 +0000 >Subject: [PATCH] Bug 36555: (QA follow-up) Tidy > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > reports/guided_reports.pl | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index 840d6081bbb..b7c722945aa 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -613,15 +613,16 @@ elsif ($op eq 'cud-share'){ > elsif ($op eq 'export'){ > > # export results to tab separated text or CSV >- my $report_id = $input->param('id'); >- my $report = Koha::Reports->find($report_id); >- my $sql = $report->savedsql; >- my @param_names = $input->multi_param('param_name'); >- my @sql_params = $input->multi_param('sql_params'); >- my $format = $input->param('format'); >- my $reportname = $input->param('reportname'); >- my $reportfilename = $reportname ? "$report_id-$reportname-reportresults.$format" : "$report_id-reportresults.$format" ; >- my $scrubber = C4::Scrubber->new(); >+ my $report_id = $input->param('id'); >+ my $report = Koha::Reports->find($report_id); >+ my $sql = $report->savedsql; >+ my @param_names = $input->multi_param('param_name'); >+ my @sql_params = $input->multi_param('sql_params'); >+ my $format = $input->param('format'); >+ my $reportname = $input->param('reportname'); >+ my $reportfilename = >+ $reportname ? "$report_id-$reportname-reportresults.$format" : "$report_id-reportresults.$format"; >+ my $scrubber = C4::Scrubber->new(); > > ($sql, undef) = $report->prep_report( \@param_names, \@sql_params ); > my ( $sth, $q_errors ) = execute_query( { sql => $sql, report_id => $report_id } ); >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36555
:
164564
|
164565
|
165954
| 165955