Attachment 166007 Details for Bug 15565 – Bug 15565: Place multiple holds on one or more records in OPAC

[patch] Bug 15565: Place multiple holds on one or more records in OPAC

Bug-15565-Place-multiple-holds-on-one-or-more-reco.patch (text/plain), 3.98 KB, created by Nick Clemens (kidclamp) on 2024-05-01 15:33:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-05-01 15:33:56 UTC

Size: 3.98 KB

patch

obsolete

>From 53e099d7a00ee52cc29803c09cfaf2d26c524b0f Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Tue, 13 Feb 2024 00:26:42 +0000
>Subject: [PATCH] Bug 15565: Place multiple holds on one or more records in
> OPAC
>
>Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> .../bootstrap/en/modules/opac-reserve.tt      | 26 +++++++++++++------
> 1 file changed, 18 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>index 34d1f4ff5b8..a307e965891 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>@@ -397,7 +397,7 @@
>                                                                 <tr class="holdable">
>                                                             [% END %]
>                                                                     <td class="copynumber" data-order="[% itemLoo.copynumber | html %]">
>-                                                                        <input type="radio" class="checkitem checkitem_[% bibitemloo.biblionumber | html %]" name="checkitem_[% bibitemloo.biblionumber | html %]" value="[% itemLoo.itemnumber | html %]" />
>+                                                                        <input type="checkbox" class="checkitem checkitem_[% bibitemloo.biblionumber | html %]" name="checkitem_[% bibitemloo.biblionumber | html %]" value="[% itemLoo.itemnumber | html %]" />
>                                                         [% ELSE %]
>                                                             [% SET unholdable_items = 1 %]
>                                                             [% IF ( itemLoo.checkout ) %]
>@@ -656,7 +656,9 @@
>             $(".confirmjs:checked").each(function() {
>                 var biblioNum = $(this).val();
>                 biblionumbers += biblioNum + "/";
>-                selections += biblioNum + "/";
>+                let select_bib = biblioNum;
>+                let select_pickup;
>+                let select_items = [];
> 
>                 // If required hold note is empty, make it visible
>                 if( $("#holdnotes_"+biblioNum).attr( 'required' ) && $("#holdnotes_"+biblioNum).val() == '' ) {
>@@ -682,23 +684,31 @@
>                 // If the 'specific copy' radio button is checked
>                 if ($("#reqspecific_" + biblioNum + ":checked").size() > 0) {
>                     // Find the selected copy
>-                    var item = $(".checkitem_" + biblioNum + ":checked");
>-                    if ($(item).size() == 0) {
>+                    var items = $(".checkitem_" + biblioNum + ":checked");
>+                    if ($(items).size() == 0) {
>                         alert( _("Expecting a specific item selection.") );
>                         badBib = biblioNum;
>                         return false;
>                     } else {
>-                      selections += $(item).val();
>+                        items.each( function(index,el){
>+                            select_items.push( $(el).val() );
>+                        });
>                     }
>                 }
>-                selections += "/";
> 
>                 // Add the pickup location
>                 var branchSel = $("#branch_" + biblioNum);
>                 if (branchSel.size() > 0) {
>-                    selections += $(branchSel).val();
>+                    select_pickup = $(branchSel).val();
>+                }
>+                if ( select_items.length > 0 ){
>+                    select_items.forEach( function(item_value,index){
>+                        selections += select_bib + "/" + item_value + "/" + select_pickup + "/";
>+                    });
>+                }
>+                else {
>+                    selections += select_bib + "/" + "/" + select_pickup + "/";
>                 }
>-                selections += "/";
>                 return true;
>             });
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 15565: 47527 | 47551 | 47552 | 50068 | 50069 | 50392 | 50393 | 56229 | 56230 | 56231 | 56232 | 56458 | 56510 | 56511 | 56512 | 56513 | 56514 | 56515 | 56517 | 56518 | 56519 | 56520 | 56521 | 56522 | 56523 | 56524 | 61244 | 61245 | 61246 | 61247 | 61248 | 61576 | 61577 | 61578 | 61579 | 61580 | 64590 | 64591 | 64592 | 64593 | 64594 | 66594 | 66595 | 66596 | 66597 | 66598 | 68759 | 68760 | 68761 | 68762 | 68763 | 71643 | 71644 | 71645 | 71646 | 71647 | 71648 | 72644 | 72645 | 72646 | 72647 | 72648 | 72649 | 78242 | 78243 | 78244 | 78245 | 78246 | 78247 | 78248 | 78266 | 78305 | 78417 | 78418 | 78419 | 78420 | 78421 | 78422 | 78423 | 78424 | 78425 | 78426 | 78712 | 78713 | 78714 | 78715 | 78716 | 78717 | 78718 | 78719 | 78720 | 78815 | 78816 | 78817 | 78818 | 78819 | 78820 | 78821 | 78822 | 78823 | 81419 | 81420 | 81421 | 81422 | 81423 | 81424 | 81425 | 81426 | 81427 | 81431 | 81449 | 81570 | 81571 | 81572 | 81573 | 81574 | 81575 | 81576 | 81577 | 81578 | 81579 | 81580 | 81581 | 82205 | 82206 | 82207 | 82208 | 82209 | 82210 | 82211 | 82212 | 82213 | 82214 | 82215 | 82216 | 82220 | 82221 | 83331 | 83332 | 83333 | 83334 | 83335 | 83336 | 83337 | 83338 | 83339 | 83340 | 83341 | 83342 | 83378 | 83380 | 83381 | 84541 | 84542 | 84543 | 84544 | 84545 | 84546 | 84547 | 84548 | 84549 | 84550 | 84551 | 84552 | 84553 | 87979 | 87980 | 87981 | 87982 | 87983 | 87984 | 87985 | 87986 | 87987 | 87988 | 87989 | 87990 | 87991 | 117128 | 117129 | 117130 | 117131 | 117132 | 117133 | 120365 | 120366 | 120367 | 120639 | 120640 | 120641 | 121941 | 122098 | 162071 | 162072 | 162073 | 162074 | 163052 | 163053 | 163054 | 163055 | 163092 | 163093 | 166005 | 166006 | 166007 | 166008 | 166009