Attachment 166017 Details for Bug 30579 – Bug 30579: (follow-up) Add required label and warning when hold levels required

[patch] Bug 30579: (follow-up) Add required label and warning when hold levels required

Bug-30579-follow-up-Add-required-label-and-warning.patch (text/plain), 2.88 KB, created by Nick Clemens (kidclamp) on 2024-05-01 16:12:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-05-01 16:12:20 UTC

Size: 2.88 KB

patch

obsolete

>From fce6d25ecd0ebb47c0207ab474da2fa95539d7ba Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 25 Oct 2023 12:13:49 +0000
>Subject: [PATCH] Bug 30579: (follow-up) Add required label and warning when
> hold levels required
>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>---
> .../prog/en/modules/reserve/request.tt              | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 45e696e88c0..575e17c68f1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -567,12 +567,24 @@
>                                     [% ELSIF force_hold_level == 'record' %]
>                                         <input type="radio" id="requestany" checked="checked" value="Any" disabled="true"/>
>                                         <input type="hidden" name="request" value="Any"/>
>+                                        <span class="error"><i>(Required)</i></span>
>                                     [% ELSE %]
>                                         <input type="radio" id="requestany" name="request" checked="checked" value="Any" />
>                                     [% END %]
>                                 </legend>
>                                 <input type="hidden" name="alreadyreserved" value="[% alreadyreserved | html %]" />
>                                 <fieldset class="enable_request_any disable_request_group disable_request_specific">
>+                                [% IF force_hold_level == 'item' # Patron has placed a item level hold previously for this record %]
>+                                    <span class="error">
>+                                        <i class="fa fa-times fa-lg" title="Cannot be put on hold"></i>
>+                                        Hold must be item level
>+                                    </span>
>+                                [% ELSIF force_hold_level == 'item_group' # Patron has placed an item group level hold previously for this record %]
>+                                    <span class="error">
>+                                        <i class="fa fa-times fa-lg" title="Cannot be put on hold"></i>
>+                                        Hold must be item group level
>+                                    </span>
>+                                [% ELSE %]
>                                     <ol>
> 
>                                         <li>
>@@ -605,6 +617,7 @@
>                                             <input type="hidden" name="holds_to_place_count" value="1" />
>                                         [% END %]
>                                     </ol>
>+                                [% END %]
> 
> 
>                                 <fieldset class="action">
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 30579: 133549 | 133550 | 133574 | 133575 | 133689 | 133690 | 134270 | 134468 | 134469 | 134491 | 134492 | 134493 | 134893 | 134894 | 140951 | 140952 | 140953 | 140954 | 148835 | 148898 | 149271 | 150767 | 150786 | 151483 | 151493 | 151558 | 154881 | 154882 | 154883 | 154886 | 157787 | 157788 | 157789 | 157790 | 157791 | 157792 | 157937 | 157938 | 157939 | 157940 | 157941 | 157942 | 157943 | 163260 | 163261 | 163262 | 163263 | 163264 | 163265 | 163266 | 163267 | 166012 | 166013 | 166014 | 166015 | 166016 | 166017 | 166018 | 166019 | 166034 | 166035 | 166036 | 166037 | 166038 | 166039 | 166040 | 166041 | 166074 | 166075 | 166076 | 166077 | 166078 | 166079 | 166080 | 166081 | 166082 | 166264 | 166265 | 166266 | 166267 | 166268 | 166269 | 166270 | 166271 | 166272 | 166273 | 166274 | 166275