Attachment 16609 Details for Bug 7639 – Bug 7639 tiny QA follow-up

[patch] Bug 7639 tiny QA follow-up

Bug-7639-tiny-QA-follow-up.patch (text/plain), 1.14 KB, created by Kyle M Hall (khall) on 2013-03-21 11:31:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2013-03-21 11:31:54 UTC

Size: 1.14 KB

patch

obsolete

>From e47521ee0e91e8f8403f595b2f054137332647c7 Mon Sep 17 00:00:00 2001
>From: Paul Poulain <paul.poulain@biblibre.com>
>Date: Thu, 21 Mar 2013 11:24:38 +0100
>Subject: [PATCH] Bug 7639 tiny QA follow-up
>
>no need to create a variable just to call to send it as parameter the line after
>---
> C4/Circulation.pm |    4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 39d0c34..ecd4ee8 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -3310,9 +3310,7 @@ sub LostItem{
>         my $borrower = C4::Members::GetMemberDetails( $borrowernumber );
> 
>         if (C4::Context->preference('WhenLostForgiveFine')){
>-            my $exemptfine=1;
>-            my $dropbox=0;
>-            my $fix = _FixOverduesOnReturn($borrowernumber, $itemnumber, $exemptfine, $dropbox);
>+            my $fix = _FixOverduesOnReturn($borrowernumber, $itemnumber, 1, 0); # 1, 0 = exemptfine, no-dropbox
>             defined($fix) or warn "_FixOverduesOnReturn($borrowernumber, $itemnumber...) failed!";  # zero is OK, check defined
>         }
>         if (C4::Context->preference('WhenLostChargeReplacementFee')){
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 7639: 9281 | 9282 | 9436 | 10662 | 10663 | 13006 | 13007 | 14961 | 14962 | 15088 | 15089 | 16593 | 16607 | 16608 | 16609 | 16729 | 16730 | 16731 | 18929 | 18930 | 18932 | 18964 | 18965 | 18966 | 19654 | 19655 | 19656 | 19657 | 20436 | 20437 | 20438 | 20439 | 20456 | 20487