Bugzilla – Attachment 166103 Details for
Bug 34972
Canceling a waiting hold from the holds over tab can make the next hold unfillable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34972: (QA follow-up) Remove second transfer from Circulation.t
Bug-34972-QA-follow-up-Remove-second-transfer-from.patch (text/plain), 1.74 KB, created by
Marcel de Rooy
on 2024-05-03 09:30:56 UTC
(
hide
)
Description:
Bug 34972: (QA follow-up) Remove second transfer from Circulation.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-05-03 09:30:56 UTC
Size:
1.74 KB
patch
obsolete
>From cef46729454872b19bf24a4a0bfcb7d7210130b1 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 3 May 2024 09:07:17 +0000 >Subject: [PATCH] Bug 34972: (QA follow-up) Remove second transfer from > Circulation.t >Content-Type: text/plain; charset=utf-8 > >Removing the manual transfer and rightaway doing the Reserve >transfer. One test description was misleading too. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Circulation.t | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 5170744e6e..766000718f 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -5974,12 +5974,8 @@ subtest 'Checkout should correctly terminate a transfer' => sub { > > my $do_transfer = 1; > ModItemTransfer( $item->itemnumber, $library_1->branchcode, >- $library_2->branchcode, 'Manual' ); >+ $library_2->branchcode, 'Reserve' ); > ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id ); >- ModItemTransfer( >- $item->itemnumber, $library_1->branchcode, >- $library_2->branchcode, 'Reserve' >- ); # To put the Reason, it's what does returns.pl... > my $hold = Koha::Holds->find($reserve_id); > is( $hold->found, 'T', 'Hold is in transit' ); > my $transfer = $item->get_transfer; >@@ -5992,7 +5988,7 @@ subtest 'Checkout should correctly terminate a transfer' => sub { > $transfer = $transfer->get_from_storage; > isnt( $transfer->datearrived, undef ); > $hold = $hold->get_from_storage; >- is( $hold->found, undef, 'Hold is waiting' ); >+ is( $hold->found, undef, 'Hold is not waiting or transit' ); > is( $hold->priority, 1, ); > }; > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34972
:
160775
|
160776
|
163471
|
163472
|
163473
|
163728
|
163729
|
163730
|
164392
|
164393
|
166024
|
166028
|
166029
|
166100
|
166101
|
166102
| 166103