Attachment 166115 Details for Bug 36503 – Bug 36503: (follow-up) Simplify code by passing by reference

[patch] Bug 36503: (follow-up) Simplify code by passing by reference

Bug-36503-follow-up-Simplify-code-by-passing-by-re.patch (text/plain), 1.51 KB, created by Martin Renvoize (ashimema) on 2024-05-03 11:48:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-05-03 11:48:54 UTC

Size: 1.51 KB

patch

obsolete

>From e7e48fdc9f57a01652845e56a91365acdd54ccb9 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 3 May 2024 12:04:19 +0100
>Subject: [PATCH] Bug 36503: (follow-up) Simplify code by passing by reference
>
>---
> Koha/Auth/Client.pm | 23 +++++++++++------------
> 1 file changed, 11 insertions(+), 12 deletions(-)
>
>diff --git a/Koha/Auth/Client.pm b/Koha/Auth/Client.pm
>index cf6d436b0e3..f39845d5915 100644
>--- a/Koha/Auth/Client.pm
>+++ b/Koha/Auth/Client.pm
>@@ -69,18 +69,17 @@ sub get_user {
>     my $domain = $self->has_valid_domain_config({ provider => $provider, email => $mapped_data->{email}, interface => $interface});
> 
>     # Call the plugin hook "auth_client_get_user" of all plugins.
>-    my $args = {
>-        provider    => $provider,
>-        data        => $data,
>-        config      => $config,
>-        mapped_data => $mapped_data,
>-        patron      => $patron,
>-        domain      => $domain,
>-    };
>-    Koha::Plugins->call('auth_client_get_user', $args);
>-    $mapped_data = $args->{'mapped_data'};
>-    $patron      = $args->{'patron'};
>-    $domain      = $args->{'domain'};
>+    Koha::Plugins->call(
>+        'auth_client_get_user',
>+        {
>+            provider    => $provider,
>+            data        => $data,
>+            config      => $config,
>+            mapped_data => $mapped_data,
>+            patron      => $patron,
>+            domain      => $domain,
>+        }
>+    );
> 
>     $patron->set($mapped_data)->store if $patron && $domain->update_on_auth;
> 
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 36503: 164379 | 164628 | 164893 | 164894 | 165466 | 166050 | 166111 | 166112 | 166113 | 166114 | 166115 | 166116 | 166458 | 166459 | 166460 | 166461 | 166462 | 166531 | 166532