Attachment 166131 Details for Bug 27753 – Bug 27753: (follow-up) Tidy introduced code in Circulation.pm

[patch] Bug 27753: (follow-up) Tidy introduced code in Circulation.pm

Bug-27753-follow-up-Tidy-introduced-code-in-Circul.patch (text/plain), 2.36 KB, created by Martin Renvoize (ashimema) on 2024-05-03 14:16:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-05-03 14:16:41 UTC

Size: 2.36 KB

patch

obsolete

>From 3c985d1beb9fdf1cc22315a3b6616d8b8483a3de Mon Sep 17 00:00:00 2001
>From: Laura Escamilla <laura.escamilla@bywatersolutions.com>
>Date: Tue, 30 Apr 2024 15:51:45 +0000
>Subject: [PATCH] Bug 27753: (follow-up) Tidy introduced code in Circulation.pm
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Circulation.pm | 40 ++++++++++++++++++++--------------------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index a83e59671c3..2e24b990759 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2536,28 +2536,28 @@ sub AddReturn {
> 
>     if ( C4::Context->preference('ClaimReturnedLostValue') ) {
> 
>-            my $claim = Koha::Checkouts::ReturnClaims->find(
>-                {
>-                    itemnumber => $item->id,
>-                    resolution => undef,
>-                }
>-            );
>-            if ($claim) {
>-                my $autoClaimReturnCheckin = C4::Context->preference('AutoClaimReturnStatusOnCheckin');
>-                if ($autoClaimReturnCheckin) {
>+        my $claim = Koha::Checkouts::ReturnClaims->find(
>+            {
>+                itemnumber => $item->id,
>+                resolution => undef,
>+            }
>+        );
>+        if ($claim) {
>+            my $autoClaimReturnCheckin = C4::Context->preference('AutoClaimReturnStatusOnCheckin');
>+            if ($autoClaimReturnCheckin) {
> 
>-                    my $patron_id  = $patron->borrowernumber;
>-                    my $resolution = $autoClaimReturnCheckin;
>+                my $patron_id  = $patron->borrowernumber;
>+                my $resolution = $autoClaimReturnCheckin;
> 
>-                    $claim->resolve(
>-                        {
>-                            resolution  => $resolution,
>-                            resolved_by => $patron_id,
>-                        }
>-                    );
>-                    $messages->{ClaimAutoResolved} = $claim;
>-                } else {
>-                    $messages->{ReturnClaims} = $claim;
>+                $claim->resolve(
>+                    {
>+                        resolution  => $resolution,
>+                        resolved_by => $patron_id,
>+                    }
>+                );
>+                $messages->{ClaimAutoResolved} = $claim;
>+            } else {
>+                $messages->{ReturnClaims} = $claim;
>             }
>         }
>     }
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 27753: 162517 | 163058 | 163059 | 163060 | 163061 | 163084 | 163085 | 163090 | 163469 | 163470 | 163474 | 163475 | 163476 | 163477 | 163479 | 163480 | 165911 | 165912 | 165914 | 165915 | 165916 | 165917 | 165918 | 165919 | 165920 | 165952 | 165953 | 165958 | 165959 | 166128 | 166129 | 166130 | 166131 | 166132 | 166133 | 166134 | 166135 | 166136 | 166137